-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: remove role assignment from Terraform #359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela-tran
added
infrastructure
Terraform, Azure, etc.
documentation
Improvements or additions to documentation
labels
Oct 30, 2023
There's a little more code cleanup to do |
thekaveman
requested changes
Oct 31, 2023
thekaveman
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And let's also delete the unused variables from the agency-specific azure-vars.yml
files.
Successfully ran the
|
thekaveman
approved these changes
Oct 31, 2023
This was referenced Oct 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #296
We found that because the pipeline service principal defaults to having
Contributor
role, it is not able to create the role assignment for the ETL principal on the Storage Container.After some discussion, we decided we should remove the role assignment from being managed by Terraform / the pipeline, and it'll be a part of the manual creation steps to set up the role assignment.
This PR deletes the role configuration from Terraform and adds documentation for the manual steps.
Pre-merge / post-merge actions
For MST, we need to
terraform state rm azurerm_role_assignment.velocity_etl[0]
so that Terraform "forgets" about the role and doesn't try to destroy it (see docs onrm
).prod
pipeline should succeed, and there's nothing left to do.For SBMTD,
prod
pipeline should succeed since now there is no permissions error to run into. The last thing to do is to manually create the role assignment for the ETL service principal. Doing so requires theOwner
role on your Azure account in the SBMTD subscription. (This has been added as a task on SBMTD Agency card server setup #297)