Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib): Remove experimental Next implementation #918

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

MrRefactor
Copy link
Collaborator

@MrRefactor MrRefactor commented Nov 21, 2024

Summary

Remove experimental scrollview based react-native-pager-view implementation.

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

ios/RNCPagerView.h Show resolved Hide resolved
ios/RNCPagerView.h Show resolved Hide resolved
ios/Fabric/RNCPagerViewComponentView.h Show resolved Hide resolved
ios/RNCPagerViewManager.m Show resolved Hide resolved
ios/RNCPagerViewManager.m Show resolved Hide resolved
@MrRefactor MrRefactor force-pushed the refactor/move-away-from-next branch 2 times, most recently from 0bcfc4e to 897c138 Compare November 22, 2024 13:20
@MrRefactor MrRefactor force-pushed the refactor/move-away-from-next branch from 897c138 to 1692bd7 Compare November 27, 2024 11:27
@MrRefactor MrRefactor force-pushed the refactor/move-away-from-next branch from 1692bd7 to 19e9d51 Compare November 27, 2024 12:20
@MrRefactor MrRefactor merged commit 48730f4 into master Nov 27, 2024
3 checks passed
@MrRefactor MrRefactor deleted the refactor/move-away-from-next branch November 27, 2024 12:49
@OlegWock
Copy link

OlegWock commented Dec 4, 2024

Hello! Would you mind me asking why you decided to not proceed with this implementation?

I'm using react-native-tab-view and currently facing this issue in my app on iOS, after some debugging I figured it's coming from react-native-pager-view. I tried a lot of stuff, but in the end what worked for me was to switch to new implementation (one removed in this PR) by monkey-patching file inside node_modules. So I was wondering if there is any (potential?) problems with new next implementation?

@sriharsha-y
Copy link

@MrRefactor Can I know what's the potential problems with this new scrollview based implementation and why it is removed ?

@MrRefactor
Copy link
Collaborator Author

Hello! Would you mind me asking why you decided to not proceed with this implementation?

I'm using react-native-tab-view and currently facing this issue in my app on iOS, after some debugging I figured it's coming from react-native-pager-view. I tried a lot of stuff, but in the end what worked for me was to switch to new implementation (one removed in this PR) by monkey-patching file inside node_modules. So I was wondering if there is any (potential?) problems with new next implementation?

Hey, please open an issue for it in this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants