-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add re-usable workflow for scans from published img and automatic… #73
Merged
DnPlas
merged 4 commits into
KF-6331-dev-branch
from
KF-6331-add-reusable-workflow-for-scan-images
Oct 15, 2024
Merged
ci: add re-usable workflow for scans from published img and automatic… #73
DnPlas
merged 4 commits into
KF-6331-dev-branch
from
KF-6331-add-reusable-workflow-for-scan-images
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reports This commit adds get-published-images-scan-and-report.yaml, a re-usable workflow that enables repositories to scan images from a public registry (in the case of the Analytics team it defaults to charmedkubeflow) and reports back the security vulnerabilities as Github issues. This workflow is intended to be used on demand (using a workflow dispatch) and on schedule, as it will be used for continuous testing of the published images a rock repository generates. Part of #69
This was referenced Oct 9, 2024
orfeas-k
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @DnPlas, left some comments:)
DnPlas
force-pushed
the
KF-6331-add-reusable-workflow-for-scan-images
branch
from
October 10, 2024 17:05
b2f1e34
to
075ce4b
Compare
orfeas-k
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some last comments, good job with the refactoring
orfeas-k
approved these changes
Oct 15, 2024
DnPlas
added a commit
that referenced
this pull request
Oct 15, 2024
feat: report vulnerabilities as GH issues and scan images from registry This commit adds: * ci: add re-usable workflow for scans from published img and automatic… (ci: add re-usable workflow for scans from published img and automatic… #73) * ci: add workflow to enable automatic vulnerability reports (ci: add workflow to enable automatic vulnerability reports #72) * chore, ci: bump artifact download/upload and checkout actions v3 -> v4 (chore, ci: bump artifact download/upload and checkout actions v3 -> v4 #71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds get-published-images-scan-and-report.yaml, a re-usable workflow that enables repositories to scan images from a public registry (in the case of the Analytics team it defaults to charmedkubeflow) and reports back the security vulnerabilities as Github issues.
This workflow is intended to be used on demand (using a workflow dispatch) and on schedule, as it will be used for continuous testing of the published images a rock repository generates.
Part of #69
For reviewers
This workflow has been tested in this fork, specifically here.
In general, we'd expect rock repositories to have exactly the same workflow for scheduled and on demand scans:.