Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] Adding documentation for AWS and Azure deployment #256

Closed
wants to merge 19 commits into from
Closed

[MISC] Adding documentation for AWS and Azure deployment #256

wants to merge 19 commits into from

Conversation

deusebio
Copy link
Contributor

No description provided.

izmalk
izmalk reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@izmalk izmalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of minor fixes and suggestions.
Mostly wording, but there is a section about Azure in the AWS file.

docs/how-to/h-deploy-aws.md Show resolved Hide resolved
docs/how-to/h-deploy-aws.md Show resolved Hide resolved
docs/how-to/h-deploy-aws.md Show resolved Hide resolved
docs/how-to/h-deploy-aws.md Outdated Show resolved Hide resolved
docs/how-to/h-deploy-aws.md Outdated Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Outdated Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Outdated Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Outdated Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Show resolved Hide resolved
@deusebio deusebio requested a review from izmalk October 23, 2024 12:26
deusebio and others added 14 commits October 25, 2024 08:58
@deusebio
[MISC] Adding documentation for AWS and Azure deployment
dc0e85f
@deusebio
fixing typos
5cde17a
@deusebio
small fix
2a6bdb8
@deusebio @izmalk
Update docs/how-to/h-deploy-aws.md
66da627 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio @izmalk
Update docs/how-to/h-deploy-aws.md
9e90014 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio @izmalk
Update docs/how-to/h-deploy-aws.md
bc20966 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio @izmalk
Update docs/how-to/h-deploy-aws.md
6fc838b 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio @izmalk
Update docs/how-to/h-deploy-azure.md
88c82d6 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio @izmalk
Update docs/how-to/h-deploy-azure.md
285e03b 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio @izmalk
Update docs/how-to/h-deploy-azure.md
4224c0e 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio @izmalk
Update docs/how-to/h-deploy-azure.md
dc4ad99 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio @izmalk
Update docs/how-to/h-deploy-aws.md
cc257c6 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio @izmalk
Apply suggestions from code review
bfa5499 
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio
review
87115f2
izmalk
izmalk requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@izmalk izmalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the quotation/admonition issues as they tend to be rendered incorrectly. The rest is optional.

@deusebio
Copy link
Contributor Author

comments addressed. Please re-review @izmalk

@deusebio deusebio requested a review from izmalk November 20, 2024 21:31
grobbie
grobbie requested changes Nov 21, 2024
View reviewed changes
Copy link

@grobbie grobbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks but the Azure example is using edge functionality that is not yet stable/GA. Please rework the example to use standard access credentials, same as the AWS example.

docs/how-to/h-deploy-aws.md Outdated Show resolved Hide resolved
docs/how-to/h-deploy-aws.md Outdated Show resolved Hide resolved
docs/how-to/h-deploy-aws.md Outdated Show resolved Hide resolved
docs/how-to/h-deploy-aws.md Show resolved Hide resolved
docs/how-to/h-deploy-aws.md Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Outdated Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Show resolved Hide resolved
docs/how-to/h-deploy-azure.md Show resolved Hide resolved
@izmalk izmalk mentioned this pull request Nov 21, 2024
Closed
izmalk
izmalk reviewed Nov 26, 2024
View reviewed changes
docs/how-to/h-deploy-aws.md Outdated Show resolved Hide resolved
@deusebio
Copy link
Contributor Author

Content copy and pasted to Discourse. This PR is superseded by #264

@deusebio deusebio closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izmalk izmalk izmalk approved these changes

@marcoppenheimer marcoppenheimer marcoppenheimer approved these changes

@a-velasco a-velasco a-velasco approved these changes

@grobbie grobbie grobbie approved these changes

Assignees

@deusebio deusebio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deusebio @grobbie @a-velasco @izmalk @marcoppenheimer