storage: Disallow volume.security.shared on cephfs
#14633
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamistao
force-pushed
the
cephfs_tests
branch
2 times, most recently
from
dae00b1 to
a211f9c
Compare
|
@masnax Could you please just look at the last commit and confirm if my changes there make sense? |
hamistao
force-pushed
the
cephfs_tests
branch
from
a211f9c to
b12cc51
Compare
…cephfs Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
hamistao
force-pushed
the
cephfs_tests
branch
from
b12cc51 to
fb08a39
Compare
tomponline
reviewed
Dec 12, 2024
| @@ -437,6 +437,8 @@ func (d *cephfs) Validate(config map[string]string) error { | |||
| // shortdesc: Whether the CephFS file system was empty on creation time | |||
| // scope: global | |||
| "volatile.pool.pristine": validate.IsAny, | |||
| // Override general 'security.shared' rule since only cephfs does not support block volumes. | |||
| "volume.security.shared": func(value string) error { return fmt.Errorf("") }, | |||
There was a problem hiding this comment.
empty error message looks odd?
tomponline
reviewed
Dec 12, 2024
|
|
||
| # security.shared is only allowed for block volumes | ||
| ! lxc storage volume set "${pool}" vol1 security.shared true || false | ||
| ! lxc storage volume set "${pool}" isoVol security.shared true || false |
There was a problem hiding this comment.
So does security.shared not work for iso volumes because they are allowed to be attached concurrently to multiple instances (as this should be allowed because they are readonly)?
There was a problem hiding this comment.
Yes, they are sharable by default
tomponline
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Please can you expand the commit message as to why these were ineffective?
|
@hamistao ceph tests failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to deny enabling
security.sharedon a cephfs pool. Also includes tests for this check and for settingsecurity.sharedin many volume types.