Fix Octavia upload image script #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The retrofit action needs an image ID. Signed-off-by: Nicolas Bock <[email protected]>
brianphaley
requested changes
Jul 31, 2024
|
|
||
| source $(realpath $(dirname $0))/../novarc | ||
|
|
||
| IMAGE_ID=$(openstack image list --name jammy --format value --column ID) |
There was a problem hiding this comment.
So this script previously took a release name via '--release foo' which is useful when running on a focal deploy. Defaulting to jammy won't work there so perhaps it should be put back, unless we can determine the release from something else?
There was a problem hiding this comment.
Ok, that's a good point. I'll work on this PR a bit more.
There was a problem hiding this comment.
I believe this is not necessary if we have #217 i.e. of an image exists in glance that corresponds to the version/release deployed (focal->ussuri, jammy->yoga etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retrofit action needs an image ID.
Signed-off-by: Nicolas Bock [email protected]