-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always build test-app presenter #2071
base: trunk
Are you sure you want to change the base?
Conversation
I would rather take the slight build hit than maintain the conditional logic and extra CI job.
@@ -85,19 +85,6 @@ jobs: | |||
|
|||
- run: xcodebuild -project redwood-layout-uiview/RedwoodLayoutUIViewTests.xcodeproj -scheme RedwoodLayoutUIViewTests -destination 'platform=iOS Simulator,name=iPhone 15,OS=latest' test | |||
|
|||
treehouse-host-check: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
Ugh, we can build the development executable, or the production executable, but not both in the same run. I guess we need to decide which one we run in CI.
|
Maybe they use different directories in KGP 2.0? Can wait and see. |
The distribution directories are different, but it still fails. I filed https://youtrack.jetbrains.com/issue/KT-68813 about it. |
I would rather take the slight build hit than maintain the conditional logic and extra CI job.
CHANGELOG.md
's "Unreleased" section has been updated, if applicable.