Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build test-app presenter #2071

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Conversation

JakeWharton
Copy link
Collaborator

I would rather take the slight build hit than maintain the conditional logic and extra CI job.


  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

I would rather take the slight build hit than maintain the conditional logic and extra CI job.
@@ -85,19 +85,6 @@ jobs:

- run: xcodebuild -project redwood-layout-uiview/RedwoodLayoutUIViewTests.xcodeproj -scheme RedwoodLayoutUIViewTests -destination 'platform=iOS Simulator,name=iPhone 15,OS=latest' test

treehouse-host-check:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@swankjesse
Copy link
Collaborator

Ugh, we can build the development executable, or the production executable, but not both in the same run.

I guess we need to decide which one we run in CI.

* What went wrong:
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
A problem was found with the configuration of task ':test-app:presenter-treehouse:jsBrowserProductionWebpack' (type 'KotlinWebpack').
  - Gradle detected a problem with the following location: '/Users/runner/work/redwood/redwood/build/js/packages/test-app-presenter-treehouse'.
    
    Reason: Task ':test-app:presenter-treehouse:jsBrowserProductionWebpack' uses this output of task ':test-app:presenter-treehouse:jsDevelopmentExecutableCompileSync' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':test-app:presenter-treehouse:jsDevelopmentExecutableCompileSync' as an input of ':test-app:presenter-treehouse:jsBrowserProductionWebpack'.
      2. Declare an explicit dependency on ':test-app:presenter-treehouse:jsDevelopmentExecutableCompileSync' from ':test-app:presenter-treehouse:jsBrowserProductionWebpack' using Task#dependsOn.
      3. Declare an explicit dependency on ':test-app:presenter-treehouse:jsDevelopmentExecutableCompileSync' from ':test-app:presenter-treehouse:jsBrowserProductionWebpack' using Task#mustRunAfter.

@JakeWharton
Copy link
Collaborator Author

Maybe they use different directories in KGP 2.0? Can wait and see.

@JakeWharton
Copy link
Collaborator Author

The distribution directories are different, but it still fails. I filed https://youtrack.jetbrains.com/issue/KT-68813 about it.

@JakeWharton JakeWharton marked this pull request as draft July 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants