Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always build test-app presenter #2071

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Always build test-app presenter #2071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,6 @@ jobs:

- run: xcodebuild -project redwood-layout-uiview/RedwoodLayoutUIViewTests.xcodeproj -scheme RedwoodLayoutUIViewTests -destination 'platform=iOS Simulator,name=iPhone 15,OS=latest' test

treehouse-host-check:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 21
- uses: gradle/actions/setup-gradle@v3

# Run the tests that transitively depend on :test-app if it's available.
- run: ./gradlew :redwood-treehouse-host:check

sample-counter:
runs-on: macos-latest
steps:
Expand Down
13 changes: 4 additions & 9 deletions redwood-treehouse-host/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,8 @@ kotlin {
}
}
jvmTest {
if (!rootProject.hasProperty('redwoodNoApps')) {
kotlin.srcDir('src/appsJvmTest/kotlin')
dependencies {
implementation projects.testApp.presenterTreehouse
}
dependencies {
implementation projects.testApp.presenterTreehouse
}
}
}
Expand Down Expand Up @@ -96,8 +93,6 @@ android {
}

// TreehouseTester expects to load our test application.
if (!rootProject.hasProperty('redwoodNoApps')) {
tasks.withType(Test.class).configureEach {
it.dependsOn(":test-app:presenter-treehouse:compileDevelopmentExecutableKotlinJsZipline")
}
tasks.withType(Test).configureEach {
it.dependsOn(":test-app:presenter-treehouse:compileDevelopmentExecutableKotlinJsZipline")
}
0 ...app/cash/redwood/treehouse/FakeHostApi.kt → ...app/cash/redwood/treehouse/FakeHostApi.kt
View file
Open in desktop
File renamed without changes.
0 ...n/app/cash/redwood/treehouse/LeaksTest.kt → ...n/app/cash/redwood/treehouse/LeaksTest.kt
View file
Open in desktop
File renamed without changes.
0 ...treehouse/RetainEverythingCodeListener.kt → ...treehouse/RetainEverythingCodeListener.kt
View file
Open in desktop
File renamed without changes.
0 ...e/RetainEverythingEventListenerFactory.kt → ...e/RetainEverythingEventListenerFactory.kt
View file
Open in desktop
File renamed without changes.
0 ...RetainEverythingTreehouseContentSource.kt → ...RetainEverythingTreehouseContentSource.kt
View file
Open in desktop
File renamed without changes.
0 ...cash/redwood/treehouse/TreehouseTester.kt → ...cash/redwood/treehouse/TreehouseTester.kt
View file
Open in desktop
File renamed without changes.
0 .../redwood/treehouse/TreehouseTesterTest.kt → .../redwood/treehouse/TreehouseTesterTest.kt
View file
Open in desktop
File renamed without changes.
0 ...sh/redwood/treehouse/leaks/CycleFinder.kt → ...sh/redwood/treehouse/leaks/CycleFinder.kt
View file
Open in desktop
File renamed without changes.
0 .../redwood/treehouse/leaks/FindCycleTest.kt → .../redwood/treehouse/leaks/FindCycleTest.kt
View file
Open in desktop
File renamed without changes.
0 ...p/cash/redwood/treehouse/leaks/JvmHeap.kt → ...p/cash/redwood/treehouse/leaks/JvmHeap.kt
View file
Open in desktop
File renamed without changes.
0 ...sh/redwood/treehouse/leaks/JvmHeapTest.kt → ...sh/redwood/treehouse/leaks/JvmHeapTest.kt
View file
Open in desktop
File renamed without changes.
0 ...sh/redwood/treehouse/leaks/LeakWatcher.kt → ...sh/redwood/treehouse/leaks/LeakWatcher.kt
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ include ':redwood-widget-compose'
include ':redwood-widget-testing'
include ':redwood-yoga'

include ':test-app:presenter'
include ':test-app:presenter-treehouse'
include ':test-app:schema'
include ':test-app:schema:compose'
include ':test-app:schema:modifiers'
Expand All @@ -98,8 +100,6 @@ if (!hasProperty('redwoodNoApps')) {
include ':test-app:browser'
include ':test-app:ios-shared'
include ':test-app:launcher'
include ':test-app:presenter'
include ':test-app:presenter-treehouse'

include ':samples:counter:android-composeui'
include ':samples:counter:android-views'
Expand Down
Loading