nuke: Avoid a TypeError w/ null node description #1883
Conversation
This avoids a `TypeError: argument of type 'NoneType' is not iterable` when nuking a node whose description is None. ex: https://sentry.ceph.com/share/issue/91172146663f4c71a6cbfe43725b2e07/ Signed-off-by: Zack Cerza <[email protected]>
| @@ -245,11 +245,11 @@ def nuke(ctx, should_unlock, sync_clocks=True, noipmi=False, keep_logs=False, sh | |||
| with parallel() as p: | |||
| for target, hostkey in ctx.config['targets'].items(): | |||
| status = get_status(target) | |||
| if ctx.name and ctx.name not in status.get('description', ""): | |||
There was a problem hiding this comment.
Does this change accomplish anything? name won't be in "" and that's a valid test, right? (in fact, couldn't it just be status.get('description'), since the default is None and name won't be in that either?)
There was a problem hiding this comment.
The bug is that we end up trying to iterate over None. This happens when status['description'] has the value None. dict.get works in such a way that the second arg is returned if there is no value for the requested key, as opposed to there being a Falsey value. So your example would have us hitting the error if status['description'] were None or "".
| total_unnuked[target] = hostkey | ||
| log.info( | ||
| f"Not nuking {target} because description doesn't match: " | ||
| f"{ctx.name} != {status['description']}" |
There was a problem hiding this comment.
This seems like the actual fix for the exception
There was a problem hiding this comment.
If you visit the Sentry event I linked in the commit message you can see that the error is on line 248
This avoids a
TypeError: argument of type 'NoneType' is not iterablewhen nuking a node whose description is None.ex: https://sentry.ceph.com/share/issue/91172146663f4c71a6cbfe43725b2e07/