Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuke: Avoid a TypeError w/ null node description #1883

Merged
merged 1 commit into from
Aug 15, 2023
Merged

nuke: Avoid a TypeError w/ null node description #1883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions teuthology/nuke/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,11 @@ def nuke(ctx, should_unlock, sync_clocks=True, noipmi=False, keep_logs=False, sh
with parallel() as p:
for target, hostkey in ctx.config['targets'].items():
status = get_status(target)
if ctx.name and ctx.name not in status.get('description', ""):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change accomplish anything? name won't be in "" and that's a valid test, right? (in fact, couldn't it just be status.get('description'), since the default is None and name won't be in that either?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug is that we end up trying to iterate over None. This happens when status['description'] has the value None. dict.get works in such a way that the second arg is returned if there is no value for the requested key, as opposed to there being a Falsey value. So your example would have us hitting the error if status['description'] were None or "".

if ctx.name and ctx.name not in (status.get('description') or ""):
total_unnuked[target] = hostkey
log.info(
f"Not nuking {target} because description doesn't match: "
f"{ctx.name} != {status['description']}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the actual fix for the exception

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you visit the Sentry event I linked in the commit message you can see that the error is on line 248

f"{ctx.name} != {status.get('description')}"
)
continue
elif status.get('up') is False:
Expand Down
Loading