Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enforce checking proofs when constraints are provided for a slot, solve TODOs #8

Merged
merged 9 commits into from
Nov 6, 2024
Merged

fix: enforce checking proofs when constraints are provided for a slot, solve TODOs #8

merged 9 commits into from
Nov 6, 2024

Conversation

thedevbirb
Copy link
Contributor

Now proofs are checked whenever the sidecar has accepted some constraints and any bid is rejected if it's doesn't contain them

@thedevbirb
fix: resolve proofs not checked when constraints are provided for a slot
9bd41d8 
Now proofs are checked whenever the sidecar has accepted some constraints and any bid is rejected if it's doesn't contain them
@merklefruit merklefruit added the bug Something isn't working label Nov 5, 2024
@thedevbirb
Copy link
Contributor Author

Tested on the devnet on works nicely on relay failures:

time="2024-11-05T18:28:12.004Z" level=warning msg="relay did not provide proofs despite existing constraints for slot" blockHash=0xfc915c704feaac8bdb3d2b7d1c272354cf4fbc06c35fb68af16eda23ba634c43 blockNumber=135 method=getHeaderWithProofs parentHash=0x0638799a5d6f6992c5cffde36cbd07362b26df4bd07600edd717ae6dad4cd5cc pubkey=0x8fda66b8607af873f4c2c8218dd3ffc7940d411047eb199b5cd010156af4845d21dd2e65b0e44cfffb5e78271e9bb29d slot=135 slotUID=180d64bf-bae8-434f-aae1-b712eecabb93 txRoot=0xdb885808af94f56baacbf6b6327b2661f76f3dd9a55c64db08efef7b9f91e970 ua=bolt-sidecar url="http://172.16.0.21:4040/eth/v1/builder/header_with_proofs/135/0x0638799a5d6f6992c5cffde36cbd07362b26df4bd07600edd717ae6dad4cd5cc/0x8fda66b8607af873f4c2c8218dd3ffc7940d411047eb199b5cd010156af4845d21dd2e65b0e44cfffb5e78271e9bb29d" value=0.000786569276767056 version=

Let's merge this once we're ready with a fix for the relay as well.
Once merged we should publish the new image with release tag v0.3.0-alpha.rc3.

@thedevbirb thedevbirb changed the title fix: enforce checking proofs when constraints are provided for a slot fix: enforce checking proofs when constraints are provided for a slot, solve TODOs Nov 6, 2024
@thedevbirb
Copy link
Contributor Author

With a little more effort it also closes #9

merklefruit
merklefruit approved these changes Nov 6, 2024
View reviewed changes
Copy link

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the early decoding

server/constraints.go Outdated Show resolved Hide resolved
server/service_test.go Outdated Show resolved Hide resolved
server/service.go Show resolved Hide resolved
server/service.go Show resolved Hide resolved
@thedevbirb
Copy link
Contributor Author

Finally ready and working in the devnet together with Helix: chainbound/helix#21

@thedevbirb thedevbirb marked this pull request as ready for review November 6, 2024 15:29
merklefruit
merklefruit reviewed Nov 6, 2024
View reviewed changes
server/proofs.go Outdated Show resolved Hide resolved
merklefruit
merklefruit approved these changes Nov 6, 2024
View reviewed changes
Copy link

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thedevbirb thedevbirb merged commit 0e08eeb into main Nov 6, 2024
0 of 2 checks passed
@thedevbirb thedevbirb deleted the lore/fix/proof-checks branch November 6, 2024 16:05
@merklefruit merklefruit mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thedevbirb @merklefruit