Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce checking proofs when constraints are provided for a slot, solve TODOs #8

Merged
merged 9 commits into from
Nov 6, 2024
Merged

fix: enforce checking proofs when constraints are provided for a slot, solve TODOs #8

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9bd41d8
fix: resolve proofs not checked when constraints are provided for a slot
thedevbirb Nov 5, 2024
7488961
chore: Transaction -> HexTransaction
thedevbirb Nov 6, 2024
b4e7749
perf(proofs): don't decode and re-marshal constraints when veryfing p…
thedevbirb Nov 6, 2024
919fb80
chore: drop TODO on unused type, remove some unused Capella code
thedevbirb Nov 6, 2024
144ad70
fix: test; useless error return instead of early return
thedevbirb Nov 6, 2024
14621f8
fix(constraints): ensure map is allocated
thedevbirb Nov 6, 2024
48fc5ed
chore: remove redundant logs; remove some warnings
thedevbirb Nov 6, 2024
79c77bb
fix(service): UnmarshalJSON of VersionedSignedBuilderBidWithProofs
thedevbirb Nov 6, 2024
53a4e3f
fix: log
thedevbirb Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 22 additions & 23 deletions server/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import (
"github.com/google/uuid"
"github.com/gorilla/mux"
"github.com/sirupsen/logrus"
log "github.com/sirupsen/logrus"
)

// Standard errors
Expand Down Expand Up @@ -452,17 +453,7 @@ func (m *BoostService) handleRevoke(w http.ResponseWriter, req *http.Request) {
}

// verifyInclusionProof verifies the proofs against the constraints, and returns an error if the proofs are invalid.
func (m *BoostService) verifyInclusionProof(transactionsRoot phase0.Root, proof *InclusionProof, slot uint64) error {
log := m.log.WithFields(logrus.Fields{})

// BOLT: get constraints for the slot
inclusionConstraints, exists := m.constraints.Get(slot)

if !exists {
log.Warnf("[BOLT]: No constraints found for slot %d", slot)
return errMissingConstraint
}

func (m *BoostService) verifyInclusionProof(transactionsRoot phase0.Root, proof *InclusionProof, inclusionConstraints map[gethCommon.Hash]*Transaction) error {
if proof == nil {
return errNilProof
}
Expand All @@ -474,7 +465,7 @@ func (m *BoostService) verifyInclusionProof(transactionsRoot phase0.Root, proof
return errHashesIndexesMismatch
}

log.Infof("[BOLT]: Verifying merkle multiproofs for %d transactions", len(proof.TransactionHashes))
m.log.Infof("verifying merkle multiproofs for %d transactions", len(proof.TransactionHashes))

// Decode the constraints, and sort them according to the utility function used
// TODO: this should be done before verification ideally
Expand Down Expand Up @@ -513,7 +504,6 @@ func (m *BoostService) verifyInclusionProof(transactionsRoot phase0.Root, proof

leaves[i] = txHashTreeRoot[:]
indexes[i] = int(proof.GeneralizedIndexes[i])
i++
}

hashes := make([][]byte, len(proof.MerkleHashes))
Expand All @@ -530,11 +520,10 @@ func (m *BoostService) verifyInclusionProof(transactionsRoot phase0.Root, proof
}

if !ok {
log.Error("[BOLT]: proof verification failed")
log.Error("merkle proof verification failed")
return errInvalidProofs
} else {
log.Info(fmt.Sprintf("[BOLT]: merkle proof verified in %s", elapsed))
}
log.Infof("merkle proof verified in %s", elapsed)

return nil
}
Expand Down Expand Up @@ -871,6 +860,10 @@ func (m *BoostService) handleGetHeaderWithProofs(w http.ResponseWriter, req *htt
result := bidResp{} // the final response, containing the highest bid (if any)
relays := make(map[BlockHashHex][]RelayEntry) // relays that sent the bid for a specific blockHash

// Get the constraints for this slot
inclusionConstraints, exists := m.constraints.Get(slotUint)
shouldCheckInclusionProofsAgainstConstraints := exists && inclusionConstraints != nil

// Call the relays
var mu sync.Mutex
var wg sync.WaitGroup
Expand Down Expand Up @@ -970,15 +963,20 @@ func (m *BoostService) handleGetHeaderWithProofs(w http.ResponseWriter, req *htt
}

// BOLT: verify inclusion proofs. If they don't match, we don't consider the bid to be valid.
if responsePayload.Proofs != nil {
if shouldCheckInclusionProofsAgainstConstraints {
if responsePayload.Proofs == nil {
log.Warn("relay did not provide proofs despite existing constraints for slot")
return
}

// BOLT: verify the proofs against the constraints. If they don't match, we don't consider the bid to be valid.
transactionsRoot, err := responsePayload.TransactionsRoot()
if err != nil {
log.WithError(err).Error("[BOLT]: error getting transaction root")
log.WithError(err).Error("error getting transaction root from relay response")
return
}
if err := m.verifyInclusionProof(transactionsRoot, responsePayload.Proofs, slotUint); err != nil {
log.Warnf("[BOLT]: Proof verification failed for relay %s: %s", relay.URL, err)
if err := m.verifyInclusionProof(transactionsRoot, responsePayload.Proofs, inclusionConstraints); err != nil {
log.Warnf("proof verification failed for relay %s", err)
return
}
}
Expand All @@ -992,9 +990,10 @@ func (m *BoostService) handleGetHeaderWithProofs(w http.ResponseWriter, req *htt
// Compare the bid with already known top bid (if any)
if !result.response.IsEmpty() {
valueDiff := bidInfo.value.Cmp(result.bidInfo.value)
if valueDiff == -1 { // current bid is less profitable than already known one
switch valueDiff {
case -1: // current bid is less profitable than already known one
return
} else if valueDiff == 0 { // current bid is equally profitable as already known one. Use hash as tiebreaker
case 0: // current bid is equally profitable as already known one. Use hash as tiebreaker
previousBidBlockHash := result.bidInfo.blockHash
if bidInfo.blockHash.String() >= previousBidBlockHash.String() {
return
Expand All @@ -1003,7 +1002,7 @@ func (m *BoostService) handleGetHeaderWithProofs(w http.ResponseWriter, req *htt
}

// Use this relay's response as mev-boost response because it's most profitable
log.Infof("new best bid. Has proofs: %v", responsePayload.Proofs != nil)
log.Infof("new best bid. expected proofs: %v, got proofs: %v", shouldCheckInclusionProofsAgainstConstraints, responsePayload.Proofs != nil)
result.response = *responsePayload.VersionedSignedBuilderBid
result.bidInfo = bidInfo
result.t = time.Now()
Expand Down
Loading