Merge pull request #592 from chainbound/lore/chore/logs

fix(sidecar): don't send empty delegations and warn about it

bolt-sidecar/src/client/constraints.rs

@@ -8,7 +8,7 @@ use ethereum_consensus::{
     deneb::mainnet::SignedBlindedBeaconBlock, Fork,
 };
 use reqwest::Url;
-use tracing::error;
+use tracing::{error, span_enabled, trace, warn, Level};
 
 use crate::{
     api::{
@@ -141,6 +141,24 @@ impl BuilderApi for ConstraintsClient {
             .cloned()
             .collect::<Vec<_>>();
 
+        if filtered_delegations.is_empty() {
+            warn!("No delegations found for the incoming validator registrations");
+            // Works also with directives like `RUST_LOG=bolt_sidecar=trace`
+            if span_enabled!(Level::TRACE) {
+                let delegations_pubkeys = self
+                    .delegations
+                    .iter()
+                    .map(|d| &d.message.validator_pubkey)
+                    .collect::<HashSet<_>>();
+                let without_delegations = validator_pubkeys
+                    .iter()
+                    .filter(|p| !delegations_pubkeys.contains(*p))
+                    .collect::<Vec<_>>();
+                trace!("validator public keys without delegations: {:?}", without_delegations);
+            }
+            return Ok(());
+        }
+
         if let Err(err) = self.delegate(&filtered_delegations).await {
             error!(?err, "Failed to propagate delegations during validator registration");
         }