Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to packages.chef.io #3920

Closed
wants to merge 1 commit into from
Closed

Remove references to packages.chef.io #3920

wants to merge 1 commit into from

Conversation

dishanktiwari2501
Copy link
Contributor

Description

[Please describe what this change achieves]

Issues Resolved

https://progresssoftware.atlassian.net/browse/CHEF-15020

Check List

@dishanktiwari2501
updated the chef package link
1881367 
Signed-off-by: Dishank Tiwari <[email protected]>
@dishanktiwari2501 dishanktiwari2501 added the Documentation Pulls PR onto docs board so they know it exists label Oct 7, 2024
@dishanktiwari2501 dishanktiwari2501 self-assigned this Oct 7, 2024
@dishanktiwari2501 dishanktiwari2501 requested a review from a team as a code owner October 7, 2024 06:34
@netlify Netlify
Copy link

netlify bot commented Oct 7, 2024

👷 Deploy Preview for chef-server processing.

Name Link
🔨 Latest commit 1881367
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/670380df63043f0008bd4388

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

IanMadd
IanMadd reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@IanMadd IanMadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if these are correct.

docs-chef-io/content/server/ctl_chef_server.md
@@ -134,7 +134,7 @@ This subcommand has the following options:

: Use to specify the location of a package. This option is not
required when packages are downloaded from
<https://packages.chef.io/>.
<https://chefdownload-commercial.chef.io/>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be true.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah https://github.com/chef/chef-server/blob/main/src/chef-server-ctl/plugins/install.rb#L47 calls into https://github.com/chef/chef-server/blob/main/omnibus/files/server-ctl-cookbooks/infra-server/recipes/add_ons_wrapper.rb#L63 and that should pull from packages.chef.io https://github.com/chef/mixlib-install?tab=readme-ov-file#get-url-for-specific-platform-and-package-version so my understanding is that packages are still downloaded from packages.chef.io

docs-chef-io/content/server/install_server_tiered.md
@@ -266,8 +266,8 @@ first downloaded to a local directory, and then installed.
**Use Downloads**

The `install` subcommand downloads packages from
<https://packages.chef.io/> by default. For systems that are not behind
a firewall (and have connectivity to <https://packages.chef.io/>), the
<https://chefdownload-commercial.chef.io/> by default. For systems that are not behind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here

docs-chef-io/content/server/reusable/md/ctl_chef_server_install_features_download.md
@@ -1,5 +1,5 @@
The `install` subcommand downloads packages from <https://packages.chef.io> by default.
For systems that are not behind a firewall (and have connectivity to <https://packages.chef.io>), these packages can be installed as described below.
The `install` subcommand downloads packages from <https://chefdownload-commercial.chef.io> by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@IanMadd
Copy link
Contributor

IanMadd commented Oct 23, 2024

Closing because these changes aren't correct.

@IanMadd IanMadd closed this Oct 23, 2024
@IanMadd IanMadd reopened this Nov 8, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IanMadd IanMadd mentioned this pull request Nov 20, 2024
Open
4 tasks
@IanMadd IanMadd closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd left review comments

@PrajaktaPurohit PrajaktaPurohit PrajaktaPurohit left review comments

Assignees

@dishanktiwari2501 dishanktiwari2501

Labels
Documentation Pulls PR onto docs board so they know it exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dishanktiwari2501 @IanMadd @PrajaktaPurohit