Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make module compatible with native ESM #3271

Merged

Conversation

targos
Copy link
Member

@targos targos commented Oct 16, 2024

  • chore: update dependencies and TypeScript config
  • feat: make module compatible with native ESM
  • chore: enable verbatimModuleSyntax TS option

@targos targos linked an issue Oct 16, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2024

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5fdb515
Status: ✅  Deploy successful!
Preview URL: https://c03e8ace.nmrium.pages.dev
Branch Preview URL: https://3269-update-dependencies-rea.nmrium.pages.dev

View logs

@targos targos marked this pull request as draft October 16, 2024 13:19
@targos targos marked this pull request as ready for review October 16, 2024 15:24
@targos targos marked this pull request as draft October 16, 2024 15:27
@targos
Copy link
Member Author

targos commented Oct 16, 2024

There's a bug in vertical toolbars that @stropitek is looking at

@targos targos marked this pull request as ready for review October 18, 2024 09:42
@targos
Copy link
Member Author

targos commented Oct 18, 2024

/cc @hamed-musallam I hope you're OK with this change. It brings NMRium closer to full modern ESM compatibility.

@targos targos changed the title Update deps, support native ESM, enable verbatimModuleSyntax option feat: make module compatible with native ESM Oct 18, 2024
@targos targos merged commit a3db8cf into main Oct 18, 2024
12 checks passed
@targos targos deleted the 3269-update-dependencies-react-science-and-support-native-esm branch October 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies (react-science) and support native ESM
1 participant