Skip to content
This repository has been archived by the owner on Jan 18, 2020. It is now read-only.

Commit

Permalink
Account for changes to workspace workflow in Cilantro
Browse files Browse the repository at this point in the history
This uses a safer way of registering custom UI elements as not to stomp on the Cilantro version and also adds the loading overlay to the workspace template that varify overrides.

Signed-off-by: Don Naegely <[email protected]>
  • Loading branch information
naegelyd committed Oct 9, 2014
1 parent 865d257 commit 95e7d1b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion varify/static/js/min/ui/workflows/workspace.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions varify/static/js/src/ui/workflows/workspace.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
/* global define */

define([
'underscore',
'cilantro',
'marionette',
'../sample',
'../../utils'
], function(c, Marionette, sample, utils) {
], function(_, c, Marionette, sample, utils) {


var WorkspaceWorkflow = c.ui.WorkspaceWorkflow.extend({
template: 'varify/workflows/workspace',

ui: {
sampleVariantSetHelp: '[data-target=sample-variant-set-help]',
createVariantSetButton: '[data-target=create-variant-set]'
ui: function() {
return _.extend({
sampleVariantSetHelp: '[data-target=sample-variant-set-help]',
createVariantSetButton: '[data-target=create-variant-set]'
}, c.ui.WorkspaceWorkflow.prototype.ui);
},

events: {
Expand Down
4 changes: 4 additions & 0 deletions varify/static/templates/workflows/workspace.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,7 @@ <h4>Variant Sets <i data-target=sample-variant-set-help class='icon icon-questio
<div data-target='public-query-region'></div>
</div>
</div>

<div class='loading-overlay hide'>
<h4><i class='icon-spinner icon-spin'></i> Loading Query</h4>
</div>

0 comments on commit 95e7d1b

Please sign in to comment.