Add apparent emitter brightness controls #1555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtional to color squared
It was accidentally removed.
- Change `Emitter intensity` to scale both emitter light intensity and apparent emitter brightness. - Add `Emitter light intensity`, which scales only the emitter light intensity.
"looks like firstReflection is only used for fog, but yeah don't want to mess with our jank xd" (NotStirred, [Discord](https://discord.com/channels/541221265512464394/545374333883777037/1079435203879129220)) Co-Authored-By: Tom Martin <[email protected]>
Peregrine05
changed the title
Co-Authored-By: Justin Barker <[email protected]>
`1/35` is approximately equal to 0.029; 0.02 would make soul torches appear too dim.
Make the per-material apparent brightness sliders behave similarly to the global ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitter intensitytoEmitter brightness, and changed it to scale both emitter light intensity and apparent emitter brightness. Changed its default value to 1.Emitter light intensity modifier, which scales only the emitter light intensity. Its default value is 13, to reflect the default value ofEmitter intensityfrom previous versions.Apparent emitter brightness modifier, which scales only the apparent brighness of emitters. Its default value is 1.Apparent brightnessmaterial property, which changes the apparent brightness of the material when it behaves as an emitter. Its default value is 1Emitter brightness(previouslyEmitter intensity) as the value ofEmitter light intensity modifier, and setEmitter brightnessto 1.New:
This PR could still use some testing, specifically with ESS. The PathTracer code might also be more complicated than it need be; we should check if there is any way to achieve the same results with simpler code (This may no longer be the case).