PG17 compatibility - Check if there are blocks left in columnar_scan_analyze_next_block #7738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7738 +/- ##
===============================================
Coverage ? 89.63%
===============================================
Files ? 274
Lines ? 59583
Branches ? 7436
===============================================
Hits ? 53409
Misses ? 4040
Partials ? 2134 |
onurctirtir
approved these changes
Nov 18, 2024
In PG17, the outer loop in acquire_sample_rows() changed from while (BlockSampler_HasMore(&bs)) to while (table_scan_analyze_next_block(scan, stream)) Relevant PG commit: 041b96802efa33d2bc9456f2ad946976b92b5ae1 postgres/postgres@041b968 It is expected that the scan_analyze_next_block function will check if there are any blocks left. So we add that check in columnar_scan_analyze_next_block (cherry picked from commit 7eb0ad5) (cherry picked from commit 196d0e7)
naisila
force-pushed
the
naisila/pg17_columnar_issue
branch
from
a162533
to
5ae350e
Compare
This was referenced Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PG17, the outer loop in
acquire_sample_rows()changedfrom
while (BlockSampler_HasMore(&bs))to
while (table_scan_analyze_next_block(scan, stream))Relevant PG commit:
041b96802efa33d2bc9456f2ad946976b92b5ae1
postgres/postgres@041b968
It is expected that the
scan_analyze_next_blockfunction willcheck if there are any blocks left. So we add that check in
columnar_scan_analyze_next_blockWithout this fix, we will have an indefinite loop causing timeout. Specifically, in our test schedules,
multi schedulestuck atdrop_column_partitioned_tabletestmulti-mxschedule stuck atstart_stop_metadata_synctestcolumnar schedulestuck atcolumnar_createtestNote to reviewer: First three commits are for PG17 testing purposes. Only the last commit will be merged.