Improve error messages in garm log #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maigl
force-pushed
the
improve_error_message
branch
from
8230b40
to
8a31d81
Compare
gabriel-samfira
requested changes
Nov 22, 2024
database/sql/jobs.go
Outdated
| @@ -244,7 +246,8 @@ func (s *sqlDatabase) CreateOrUpdateJob(ctx context.Context, job params.Job) (pa | |||
| if err == nil { | |||
| workflowJob.InstanceID = &instance.ID | |||
| } else { | |||
| slog.With(slog.Any("error", err)).ErrorContext(ctx, "failed to get instance by name") | |||
| // This usually is very normal as not all jobs run on our runners. | |||
| slog.DebugContext(ctx, fmt.Sprintf("failed to get instance by name: %s", job.RunnerName)) | |||
There was a problem hiding this comment.
same as above. The level change to DebugContext is fine.
Co-authored-by: Gabriel <[email protected]>
maigl
force-pushed
the
improve_error_message
branch
from
8255c5f
to
d6de596
Compare
gabriel-samfira
approved these changes
Nov 22, 2024
|
I think we need to bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finding errors in logs is very important and there are some logs that are
errorsbut seem to be rather normal:ourrunners. This always happens in a scenario where our garm runners are not the only runner setup (and we still get the workflow_job events, e.g. enterprise wide hooks)