[C3] Address e2e flakiness

[jculvey]

Includes a couple of changes to hopefully address flakiness in e2e tests:

• Adds a brief wait before entering interactive inputs to frameworks that require them
• Verifies that projects are ready for deployment before proceeding with deploy
• Bumps the node version to 18.17.1 in the test runs to fix astro dropping support for v16
• Specifies timeouts at the test level instead of via global config
• Allows for quarantining problematic tests suites, and adds next for now. These test suites will still run but won't block merges.

Reviewer is to perform the following, as applicable:

• Checked for inclusion of relevant tests
• Checked for inclusion of a relevant changeset
• Checked for creation of associated docs updates
• Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

[changeset-bot]

⚠️ No Changeset found

Latest commit: f6e0dea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6087734672/npm-package-wrangler-3877

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6087734672/npm-package-wrangler-3877

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6087734672/npm-package-wrangler-3877 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6087734672/npm-package-cloudflare-pages-shared-3877

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	3.20230904.0	3.20230904.0
workerd	1.20230904.0	1.20230904.0

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

Merging #3877 (f6e0dea) into main (c2f1b68) will decrease coverage by 0.13%.
Report is 9 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3877      +/-   ##
==========================================
- Coverage   75.25%   75.12%   -0.13%     
==========================================
  Files         195      195              
  Lines       11452    11482      +30     
  Branches     3022     3033      +11     
==========================================
+ Hits         8618     8626       +8     
- Misses       2834     2856      +22     

see 9 files with indirect coverage changes

[IgorMinar]

nice set of updates!

[petebacondarwin]

Is it only Astro v4 that needs node.js 18? If so, then could we avoid bumping that framework in this PR, which would allow us to avoid the breaking change and major version bump.

Then we can bump Astro and, if necessary, the node.js version in a later PR.

[jculvey]

Is it only Astro v4 that needs node.js 18? If so, then could we avoid bumping that framework in this PR, which would allow us to avoid the breaking change and major version bump.

Then we can bump Astro and, if necessary, the node.js version in a later PR.

Unfortunately it's not just Astro v4. I discovered this on an e2e run before I made this PR because the existing version of Astro we're using no longer works with node v16. I think when they released these changes they failed to pin create-astro to an astro version that supports node v16.

This can be confirmed by running npm create cloudflare@latest with node v16 and selecting astro. Even the underlying commands npm create [email protected] followed by npx astro add cloudflare-pages with node v16, it will fail.

This kind of puts us in a pickle because to get the tests to work, we need to either bump the node version or quarantine/skip the astro tests.

[petebacondarwin]

No longer needs a changeset?

[jculvey]

done 👍