chore(ui): migrate Select component to TypeScript #571

barsukov · 2024-10-28T20:33:33Z

Summary

Migrated the Select, SelectOption, SelectDivider components to TypeScript
Deprecate components Select, SelectOption,
Utilised static typing.

Changes Made

TypeScript Migration:

Converted Select, SelectOption, SelectDivider component files to TypeScript.
Added comprehensive type annotations.
Introduced a deprecated Select, SelectOption component for Javascript files.
Modify and simplify SelectRow component

Refactoring:

Made necessary adjustments to address TypeScript-detected issues.
Further refactored for cleaner and more understandable code.

Testing:

Removed AppShellProvider component from tests and stories, as not yet converted. But replace it with PortalProvider cause it should be a more accurate use case, since stories use PortalProvider instead.
Verified component behaviour using Storybook.
Updated tests to use vitest.

Release:

Generated a changeset file.

Related Issues

[TASK](ui): Migrate Select(All related) component to TypeScript #249

Testing Instructions

Run Storybook
Run Select, SelectOption, SelectDivider tests

Checklist

I have performed a self-review of my code.
I have commented my code, particularly in hard-to-understand areas.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.
I have made corresponding changes to the documentation (if applicable).
My changes generate no new warnings or errors.

changeset-bot · 2024-10-28T20:33:37Z

🦋 Changeset detected

Latest commit: fbbad56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudoperators/juno-ui-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-10-28T20:35:47Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-04 08:57 UTC

guoda-puidokaite

Starting to review this component now. Here's an initial observation regarding imports. Not a blocking change at all, but would love to see the imports cleaned up and default directory exports utilised.

packages/ui-components/src/index.js

packages/ui-components/src/components/FormRow/FormRow.stories.js

packages/ui-components/src/components/SelectOption/SelectOption.component.tsx

barsukov · 2024-10-29T10:04:23Z

@guoda-puidokaite regarding export/import lets focus on migration make same way it iwas before then we would decide where we wanna go with it later with whoel project.

guoda-puidokaite · 2024-10-29T10:08:27Z

Yah, not a blocking change for this PR as I mentioned. 🤪 But wanted to bring it up and see what you think. We can talk about it in the future. 🚀

guoda-puidokaite

Looks greattt! 🚀

Just had a few curious questions, code improvements and one type addition (most important requested change for ticket).

Thank You!

packages/ui-components/src/components/Select/Select.component.tsx

packages/ui-components/src/components/SelectDivider/SelectDivider.component.tsx

packages/ui-components/src/components/SelectOption/SelectOption.component.tsx

packages/ui-components/src/components/SelectRow/SelectRow.stories.js

barsukov · 2024-10-29T13:09:31Z

I really think that some change requests are good improvements, but others I would not mix up with migration. Migration is migration, we need to move trhough as carefull and quick as possible. Then later on we could be more dedicated on refactoring topics, but it is nice that you point some staff out @guoda-puidokaite

guoda-puidokaite · 2024-10-29T13:42:49Z

As mentioned, only the type addition boolean change is a requested change. Rest I'm asking questions about, maybe some topics are worth bringing to the improvements EPIC. And some not. 😉🚀

packages/ui-components/src/components/SelectOption/SelectOption.test.tsx

guoda-puidokaite

Super niiice! One more down. Thank Youuu! 💪

packages/ui-components/src/components/FormHint/FormHint.component.tsx

packages/ui-components/src/components/Select/Select.component.tsx

edda

👍 🚀
Only one small change request.

guoda-puidokaite

Thank You! 🚀💪✅

* chore(ui): migrate select component * chore(ui): move FormRow to deprecated * chore(ui): add components to deprecated * chore(ui): last clean up * chore(ui): bring the status quo for FormRow * chore(ui): deprecated change * chore(ui): fix select story * chore(ui): rollback some changes and fix tests * chore(ui): add changeset * chore(ui): update index.js * chore(ui): minor review changes * chore(ui): minor ui issue * chore(ui): remove redundancy * fix(ui): removes html id prop from interface * fix(ui): extend interface to mirror underlying HTML elem props --------- fixes #249 Co-authored-by: Esther Schmitz <[email protected]>

barsukov added 11 commits October 24, 2024 16:13

chore(ui): migrate select component

ce3aa93

chore(ui): move FormRow to deprecated

214bf1f

chore(ui): add components to deprecated

5df9b58

chore(ui): last clean up

291b323

chore(ui): bring the status quo for FormRow

d7381e6

chore(ui): deprecated change

e10e394

chore(ui): fix select story

7b2f9ba

chore(ui): rollback some changes and fix tests

a8da52d

chore(ui): add changeset

04016a8

chore(ui): update index.js

352ee9e

Merge branch 'main' into wowa-select-ts

8284ba2

barsukov added the ui-components All tasks related to juno-ui-components library label Oct 28, 2024

barsukov added this to the TypeScript Migration of Juno Core milestone Oct 28, 2024

barsukov self-assigned this Oct 28, 2024

barsukov added the draft label Oct 28, 2024

barsukov marked this pull request as ready for review October 28, 2024 20:51

barsukov requested review from franzheidl and a team as code owners October 28, 2024 20:51

barsukov removed the draft label Oct 29, 2024

guoda-puidokaite reviewed Oct 29, 2024

View reviewed changes

packages/ui-components/src/index.js Show resolved Hide resolved

packages/ui-components/src/components/FormRow/FormRow.stories.js Show resolved Hide resolved

packages/ui-components/src/components/SelectOption/SelectOption.component.tsx Show resolved Hide resolved

guoda-puidokaite mentioned this pull request Oct 29, 2024

chore(ui): migrate AppShellProvider and CodeBlock to TypeScript #547

Merged

6 tasks

guoda-puidokaite requested changes Oct 29, 2024

View reviewed changes

barsukov added 2 commits October 30, 2024 09:30

chore(ui): minor review changes

9b4e9bd

chore(ui): minor ui issue

e8a44c7

barsukov and others added 2 commits October 30, 2024 09:49

chore(ui): remove redundancy

ca857bc

Merge branch 'main' into wowa-select-ts

08c5bdb

taymoor89 reviewed Oct 30, 2024

View reviewed changes

packages/ui-components/src/components/SelectOption/SelectOption.test.tsx Show resolved Hide resolved

packages/ui-components/src/components/SelectOption/SelectOption.test.tsx Show resolved Hide resolved

taymoor89 previously approved these changes Oct 30, 2024

View reviewed changes

guoda-puidokaite previously approved these changes Oct 30, 2024

View reviewed changes

barsukov requested a review from edda October 30, 2024 15:48

barsukov mentioned this pull request Oct 30, 2024

[EPIC](ui): Inconsistencies and Improvement Collection #570

Open

26 tasks

edda reviewed Oct 31, 2024

View reviewed changes

packages/ui-components/src/components/FormHint/FormHint.component.tsx Outdated Show resolved Hide resolved

packages/ui-components/src/components/Select/Select.component.tsx Show resolved Hide resolved

edda requested changes Oct 31, 2024

View reviewed changes

edda added 2 commits November 1, 2024 10:18

fix(ui): removes html id prop from interface

43bff6e

fix(ui): extend interface to mirror underlying HTML elem props

a71c9a7

edda dismissed stale reviews from guoda-puidokaite and taymoor89 via a71c9a7 November 1, 2024 09:57

edda approved these changes Nov 1, 2024

View reviewed changes

guoda-puidokaite approved these changes Nov 4, 2024

View reviewed changes

Merge branch 'main' into wowa-select-ts

fbbad56

barsukov merged commit d4167c9 into main Nov 4, 2024
15 checks passed

barsukov deleted the wowa-select-ts branch November 4, 2024 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ui): migrate Select component to TypeScript #571

chore(ui): migrate Select component to TypeScript #571

barsukov commented Oct 28, 2024

changeset-bot bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading

guoda-puidokaite left a comment

barsukov commented Oct 29, 2024

guoda-puidokaite commented Oct 29, 2024

guoda-puidokaite left a comment

barsukov commented Oct 29, 2024

guoda-puidokaite commented Oct 29, 2024

guoda-puidokaite left a comment

edda left a comment

guoda-puidokaite left a comment

chore(ui): migrate Select component to TypeScript #571

chore(ui): migrate Select component to TypeScript #571

Conversation

barsukov commented Oct 28, 2024

Summary

Changes Made

Related Issues

Testing Instructions

Checklist

changeset-bot bot commented Oct 28, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Oct 28, 2024 • edited Loading

guoda-puidokaite left a comment

Choose a reason for hiding this comment

barsukov commented Oct 29, 2024

guoda-puidokaite commented Oct 29, 2024

guoda-puidokaite left a comment

Choose a reason for hiding this comment

barsukov commented Oct 29, 2024

guoda-puidokaite commented Oct 29, 2024

guoda-puidokaite left a comment

Choose a reason for hiding this comment

edda left a comment

Choose a reason for hiding this comment

guoda-puidokaite left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading