Uodated GEM-CSC triager LUTs #13

giovanni-mocellin · 2022-06-15T08:58:38Z

This PR contains changes to the GEM-CSC trigger lookup tables to match the ones used in the CSC OTMB FW.

The main changes are:

Removal of non-used redundant LUTs for GE1/1 laver 1 and 2
Update of the LUT file names, to better reflect their content and usage
LUT length increased and fixed to 256 lines - needed for FW

This PR is linked to a PR to be submitted to CMSSW master, which uses these LUT files. A link to this PR will be added to the description of the parallel one in CMSSW.

preliminary reduction and renaming of tables

new nomenclature and updated tables with increased bit length

cmsbuild · 2022-06-15T08:59:01Z

A new Pull Request was created by @giovanni-mocellin for branch master.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @missirol, @ptcox, @Martin-Grunewald, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

tvami · 2022-07-15T10:44:34Z

@cecilecaillol I believe you'd need to sign this too

cecilecaillol · 2022-07-15T10:54:40Z

+l1

cecilecaillol · 2022-07-15T10:54:47Z

please test

cmsbuild · 2022-07-15T15:22:20Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b70d8/26258/summary.html
COMMIT: 455bcf0
CMSSW: CMSSW_12_5_X_2022-07-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b70d8/26258/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b70d8/26258/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestSubProcess had ERRORS
---> test testPhase2PixelNtuple had ERRORS

RelVals

139.001

----- Begin Fatal Exception 15-Jul-2022 16:40:38 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'packGmtStage2'
   [5] Prefetching for module L1TMuonEndCapShowerProducer/'simEmtfShowers'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11_even_GE11_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB
----- End Fatal Exception -------------------------------------------------

312.0

----- Begin Fatal Exception 15-Jul-2022 16:45:53 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module CSCDigiToRawModule/'cscpacker'
   [5] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [6] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11_even_GE11_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO
----- End Fatal Exception -------------------------------------------------

11634.0

----- Begin Fatal Exception 15-Jul-2022 16:53:10 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module CSCDigiToRawModule/'cscpacker'
   [5] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [6] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11_even_GE11_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 15-Jul-2022 16:37:39 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 2
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11_even_GE11_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 15-Jul-2022 16:37:45 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 2
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11_even_GE11_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_HIon
----- End Fatal Exception -------------------------------------------------

hlt_mc_PIon

----- Begin Fatal Exception 15-Jul-2022 16:37:44 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 1
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11_even_GE11_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26258/CMSSW_12_5_X_2022-07-14-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/poison:/cvmfs/cms-ib.cern.ch/week1/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-14-2300/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_PIon
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

tvami · 2022-07-15T15:26:54Z

@cmsbuild please test with cms-sw/cmssw#38373

cmsbuild · 2022-07-15T17:59:27Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b70d8/26268/summary.html
COMMIT: 455bcf0
CMSSW: CMSSW_12_5_X_2022-07-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-CSCTriggerPrimitives/13/26268/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b70d8/26268/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b70d8/26268/git-merge-result

RelVals

138.4138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log
139.001139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB/step2_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB.log
138.5138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3/step2_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3.log

tvami · 2022-07-17T10:45:06Z

@cmsbuild please test with cms-sw/cmssw#38373

cmsbuild · 2022-07-17T17:43:37Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b70d8/26290/summary.html
COMMIT: 455bcf0
CMSSW: CMSSW_12_5_X_2022-07-17-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-CSCTriggerPrimitives/13/26290/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

138.4138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log
139.001139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB/step2_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB.log
138.5138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3/step2_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3.log

tvami · 2022-07-18T09:40:02Z

@cmsbuild please test with cms-sw/cmssw#38373 and cms-sw/cmssw#38775

perrotta · 2022-07-22T05:36:41Z

merge
Succesfully tested witsh #38373, see cms-sw/cmssw#38373 (comment)

rathjd and others added 4 commits March 28, 2022 14:33

preliminary reduction and renaming of tables

070d1e7

Merge pull request #1 from rathjd/master

dd1f978

preliminary reduction and renaming of tables

new nomenclature and updated tables with increased bit length

e63f533

Merge pull request #2 from rathjd/master

455bcf0

new nomenclature and updated tables with increased bit length

cmsbuild added externals-pending l1-pending orp-pending pending-signatures tests-pending labels Jun 15, 2022

tvami mentioned this pull request Jun 15, 2022

Update of GEM & CSC trigger primitive emulators cms-sw/cmssw#38373

Merged

giovanni-mocellin mentioned this pull request Jul 14, 2022

[12_4_X] Updated GEM&CSC trigger primitive emulators cms-sw/cmssw#38722

Merged

cmsbuild added l1-approved tests-started and removed l1-pending tests-pending labels Jul 15, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 15, 2022

cmsbuild added requires-external tests-started and removed tests-rejected labels Jul 15, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 15, 2022

cmsbuild added tests-started and removed tests-rejected labels Jul 17, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 17, 2022

cmsbuild added orp-approved and removed orp-pending labels Jul 22, 2022

cmsbuild merged commit 74f1fda into cms-data:master Jul 22, 2022

cmsbuild mentioned this pull request Jul 22, 2022

Update tag for L1Trigger-CSCTriggerPrimitives to V00-12-00 cms-sw/cmsdist#8003

Merged

This was referenced Jul 22, 2022

Add wfs to test Run3 skims cms-sw/cmssw#38830

Merged

throw in IBooker::bookME when illegal characters for the DQM GUI upload are encountered cms-sw/cmssw#38831

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uodated GEM-CSC triager LUTs #13

Uodated GEM-CSC triager LUTs #13

giovanni-mocellin commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

tvami commented Jul 15, 2022

cecilecaillol commented Jul 15, 2022

cecilecaillol commented Jul 15, 2022

cmsbuild commented Jul 15, 2022

tvami commented Jul 15, 2022

cmsbuild commented Jul 15, 2022

tvami commented Jul 17, 2022

cmsbuild commented Jul 17, 2022

tvami commented Jul 18, 2022

perrotta commented Jul 22, 2022

Uodated GEM-CSC triager LUTs #13

Uodated GEM-CSC triager LUTs #13

Conversation

giovanni-mocellin commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

tvami commented Jul 15, 2022

cecilecaillol commented Jul 15, 2022

cecilecaillol commented Jul 15, 2022

cmsbuild commented Jul 15, 2022

Unit Tests

RelVals

AddOn Tests

tvami commented Jul 15, 2022

cmsbuild commented Jul 15, 2022

RelVals

tvami commented Jul 17, 2022

cmsbuild commented Jul 17, 2022

RelVals

tvami commented Jul 18, 2022

perrotta commented Jul 22, 2022