Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw in IBooker::bookME when illegal characters for the DQM GUI upload are encountered #38831

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 22, 2022

PR description:

Title says it all, early detection of MonitorElement path names that will have troubles indexing in the CMS Offline DQM GUI database, as per suggestion at #38814 (comment)

PR validation:

cmssw compiles.
Tested by running:

cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiStripHitEff --conditions 123X_dataRun2_v2 --scenario pp --data --era Run2_2018 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 10000 --dasquery='file dataset=/StreamExpress/Run2018D-SiStripCalMinBias-Express-v1/ALCARECO run=325172' --nThreads=4

in CMSSW_12_5_X_2022-07-21-2300 (which does not contain #38823) and obtained

----- Begin Fatal Exception 22-Jul-2022 14:16:55 CEST-----------------------
An exception of category 'BadMonitorElementPathName' occurred while
   [0] Processing  stream begin Run run: 325172 stream: 3
   [1] Calling method for module SiStripHitEfficiencyWorker/'ALCARECOSiStripHitEff'
Exception Message:
 Monitor element path name: 'AlCaReco/SiStripHitEfficiency/MissingHits/TIB1: Map of missing hits' uses unacceptable characters.
 Acceptable characters are: /ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-+=_()# 
----- End Fatal Exception -------------------------------------------------

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich mmusich force-pushed the safeCharsForDQMUpload branch from 0e25a4f to 2f0293e Compare July 22, 2022 12:12
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38831/31207

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@mmusich mmusich force-pushed the safeCharsForDQMUpload branch from 1a1061d to 1d0e439 Compare July 22, 2022 12:22
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38831/31209

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQMServices/Core (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 22, 2022

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea6ac/26395/summary.html
COMMIT: 1d0e439
CMSSW: CMSSW_12_5_X_2022-07-21-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea6ac/26395/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea6ac/26395/git-merge-result

RelVals

----- Begin Fatal Exception 22-Jul-2022 15:17:45 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module CSCTriggerPrimitivesProducer/'valCscStage2Digis'
   [3] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11a_even_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Jul-2022 15:19:32 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'packGmtStage2'
   [5] Prefetching for module L1TMuonEndCapShowerProducer/'simEmtfShowers'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11a_even_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Jul-2022 15:20:30 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_9_step'
   [2] Prefetching for module CSCTriggerPrimitivesProducer/'valCscStage2Digis'
   [3] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11a_even_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 136.897136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3/step2_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3.log
  • 136.899136.899_RunCosmics2021CRAFT+RunCosmics2021CRAFT+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3/step2_RunCosmics2021CRAFT+RunCosmics2021CRAFT+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3.log
  • 138.1138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 22-Jul-2022 15:16:49 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 3
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11a_even_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Jul-2022 15:16:49 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 1
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11a_even_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_HIon
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Jul-2022 15:17:11 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 3
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11a_even_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26395/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_PIon
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@giovanni-mocellin
Copy link
Contributor

Hi all,
I see from the errors, that the issue you're having here are related to my recent PR (which is now merged, in fact).
If you want to do the tests with it included, you also need to include another PR from cms-data (which is now merged): cms-data/L1Trigger-CSCTriggerPrimitives#13

@mmusich
Copy link
Contributor Author

mmusich commented Jul 22, 2022

I think it happened synchronously

Apparently the external update was not picked by the last IB, otherwise there would not be errors... so it was not done in the right order

@perrotta
Copy link
Contributor

perrotta commented Jul 22, 2022

Apparently the external update was not picked by the last IB, otherwise there would not be errors... so it was not done in the right order

CMSSW_12_5_X_2022-07-22-1100 includes both #38373 and cms-data/L1Trigger-CSCTriggerPrimitives#13, as you can see from the IB pages, which in fact show no error.

The tests of this PR picked only the CMSSW PR, as you can see from #38831 (comment). I imagine it was based on some HEAD of the master at that time, which does not include the newly added externals, rather than on some stable IB. That's why you needed to run it (in reality the merge of this PR plus #38825 #38373 and #38823) together with the external needed by one of the added PRs

@mmusich
Copy link
Contributor Author

mmusich commented Jul 22, 2022

@perrotta

I imagine it was based on some HEAD of the master at that time, which does not include the newly added externals, rather than on some stable IB.

That's correct, but then does it mean that the HEAD of master after a stable IB has been built (including externals) does not contain the most updated external state?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea6ac/26398/summary.html
COMMIT: 1d0e439
CMSSW: CMSSW_12_5_X_2022-07-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38831/26398/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea6ac/26398/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea6ac/26398/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3706484
  • DQMHistoTests: Total failures: 562
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3705900
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 2 / 50 workflows

@perrotta
Copy link
Contributor

That's correct, but then does it mean that the HEAD of master after a stable IB has been built (including externals) does not contain the most updated external state?

Exact! The HEAD on top of an IB is not built, and therefore it doesn't add externals beyond those which were already in the base IB

@mmusich
Copy link
Contributor Author

mmusich commented Jul 25, 2022

@cmsbuild, please test

  • to get rid of the external required flag

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea6ac/26435/summary.html
COMMIT: 1d0e439
CMSSW: CMSSW_12_5_X_2022-07-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38831/26435/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3667670
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3667640
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants