-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw in IBooker::bookME
when illegal characters for the DQM GUI upload are encountered
#38831
Conversation
b6bfd73
to
0e25a4f
Compare
0e25a4f
to
2f0293e
Compare
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38831/31207
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
2f0293e
to
1a1061d
Compare
…ad are encountered
1a1061d
to
1d0e439
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38831/31209
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals RelVals-INPUT AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals
Expand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
AddOn Tests
Expand to see more addon errors ... |
Hi all, |
Apparently the external update was not picked by the last IB, otherwise there would not be errors... so it was not done in the right order |
CMSSW_12_5_X_2022-07-22-1100 includes both #38373 and cms-data/L1Trigger-CSCTriggerPrimitives#13, as you can see from the IB pages, which in fact show no error. The tests of this PR picked only the CMSSW PR, as you can see from #38831 (comment). I imagine it was based on some HEAD of the master at that time, which does not include the newly added externals, rather than on some stable IB. That's why you needed to run it (in reality the merge of this PR plus #38825 #38373 and #38823) together with the external needed by one of the added PRs |
That's correct, but then does it mean that the HEAD of master after a stable IB has been built (including externals) does not contain the most updated external state? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea6ac/26398/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Exact! The HEAD on top of an IB is not built, and therefore it doesn't add externals beyond those which were already in the base IB |
@cmsbuild, please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea6ac/26435/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title says it all, early detection of
MonitorElement
path names that will have troubles indexing in the CMS Offline DQM GUI database, as per suggestion at #38814 (comment)PR validation:
cmssw
compiles.Tested by running:
cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiStripHitEff --conditions 123X_dataRun2_v2 --scenario pp --data --era Run2_2018 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 10000 --dasquery='file dataset=/StreamExpress/Run2018D-SiStripCalMinBias-Express-v1/ALCARECO run=325172' --nThreads=4
in
CMSSW_12_5_X_2022-07-21-2300
(which does not contain #38823) and obtainedIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A