TOTEM nT2 unpacker

[forthommel]

PR description:

We introduce the unpacker and DIGI-level data format for the new TOTEM T2 telescope (or nT2) to operate in Autumn 2022 special pp and HI runs.
nT2 digis are reflecting the registers commonly used for detectors with timing capability: channel, GEOid, and channel status marker for the labelling, and leading+trailing edges measurements for the timing part.
Additionally, a new DetId object (derived from CTPPSDetId to avoid code duplication) is introduced for the mapping of all channels/tiles in each plane of both arms.

This new detector is assigned the FED ID 577, initially used along run 2 as a TOTEM trigger counter and since then unused. Therefore, it replaces this counter unpacking in the PPS standard sequence. For the purpose of the end of 2022 HI run a nT2-only sequence will be introduced in a follow-up PR including the DIGI-to-RecHit conversion (thanks to the addition and usage of the geometry CondFormat linking digis to spatial coordinates).

Finally, work is ongoing on the DQM component, and will also be the object of a follow-up PR.

PR validation:

A fake mapping of nT2 channels was introduced to redirect the PPS diamond detector (sharing a common VFAT frame payload) into the nT2 raw-to-digi unpacker. Although the diamond data format does not follow nT2's the bitwise readout of all frames was performed successfully following the data format implemented by TOTEM DAQ experts.
This mapping is left as an example, to be replaced with the actual one after the detector installation, and converted into a payload to be GT'ed.

Furthermore, the usual matrix tests passed flawlessly.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38886/31318

• This PR adds an extra 216KB to repository

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

• CalibPPS/ESProducers (alca)
• CondFormats/PPSObjects (alca)
• DataFormats/CTPPSDetId (simulation)
• DataFormats/FEDRawData (daq)
• DataFormats/TotemReco (****)
• EventFilter/CTPPSRawToDigi (reconstruction)

The following packages do not have a category, yet:

DataFormats/TotemReco
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@malbouis, @civanch, @yuanchao, @emeschi, @clacaputo, @cmsbuild, @mdhildreth, @jpata, @tvami, @ChrisMisan, @smorovic, @francescobrivio can you please review it and eventually sign? Thanks.
@fabferro, @rovere, @Martin-Grunewald, @missirol, @tocheng, @grzanka, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

type ctpps, new-feature

[ChrisMisan]

please test

[ChrisMisan]

please abort

[civanch]

+1

[forthommel]

Glad to see no rebase is needed to include #38905.
@jpata, @clacaputo, any help needed in your review?

[smuzaffar]

I think that a possible "squash-without-merging" botton could be extremely more useful here. Maybe something we can think about with @cms-sw/core-l2 , or @smuzaffar (as soon as he's back from vacations)

@perrotta , cms bot rely on PR merge commit to properly track the merged PRs. squash-without-merging does not generate the extra merge commit and this can cause bot to not show such PRs in release notes and IB pages

[forthommel]

More food for thought that clearly go beyond the scope of this very simple PR :)
@jpata, @clacaputo, any help needed in your review?

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

please test
to refresh

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0b05c/26677/summary.html
COMMIT: e06897d
CMSSW: CMSSW_12_5_X_2022-08-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38886/26677/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a0b05c/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 42 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3691900
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3691858
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 216 log files, 49 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[forthommel]

It seems that everything remains stable wrt the previous battery of tests :)

[qliphy]

+1