feat: use delphi-logger #1469
Closed
feat: use delphi-logger #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update requirements files to use git repo * import logger from delphi-logger package instead of relative * remove duplicate logger.py in this repo * update delphi-epidata.py client to only depend on logger
|
SNAG: PyPI doesn't accept packages that declare dependencies using direct URLs. This means we'd have to get |
|
Closed in favor of #1486 |
|
Actually, gonna convert this PR to switching the server and acquisition code to use |
|
|
its up to you, but i think its worth it to create a new PR for the changes |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1467 (comment).
Related: cmu-delphi/covidcast-indicators#1970
Summary:
Prerequisites:
devbranchdev