-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Djm/pkgdown prettier #379
Djm/pkgdown prettier #379
Conversation
@brookslogan needs |
I think we're still trying to decide on branch organization --- it appears that pkgdown lets you build main & dev documentation sites independently of how you organize your branches (instead basing it on whether you use a 3-number or 4-number version tag) --- but I believe we decided to try to standardize the appearance across both main & dev sites rather than maintain separate styles. So I will try to merge this in. One thing we need to check is whether there is some auto-differentiation of style by pkgdown using red text for dev version numbers that may not be visible against a red bar at the top. |
Looks good, but before approving & merging, checking about provenance. (Certain themes are exclusive to tidyverse or some other universe/org.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provenance: epipredict styling copied here was by @dajmcdon following https://pkgdown.r-lib.org/articles/customise.html.
Because |
Oh, dev didn't exist because #383 wasn't finished yet. No wonder there were no conflicts. |
Improve the pkgdown site (nice and red and matches
epipredict
).Checks fail until #377 is merged.