Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Djm/pkgdown prettier #379

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Djm/pkgdown prettier #379

merged 3 commits into from
Dec 11, 2023

Conversation

dajmcdon
Copy link
Contributor

@dajmcdon dajmcdon commented Nov 27, 2023

Improve the pkgdown site (nice and red and matches epipredict).

Checks fail until #377 is merged.

@dajmcdon
Copy link
Contributor Author

@brookslogan needs ds/clean to pass checks (at least).

@brookslogan
Copy link
Contributor

I think we're still trying to decide on branch organization --- it appears that pkgdown lets you build main & dev documentation sites independently of how you organize your branches (instead basing it on whether you use a 3-number or 4-number version tag) --- but I believe we decided to try to standardize the appearance across both main & dev sites rather than maintain separate styles. So I will try to merge this in. One thing we need to check is whether there is some auto-differentiation of style by pkgdown using red text for dev version numbers that may not be visible against a red bar at the top.

@brookslogan
Copy link
Contributor

Looks good, but before approving & merging, checking about provenance. (Certain themes are exclusive to tidyverse or some other universe/org.)

Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provenance: epipredict styling copied here was by @dajmcdon following https://pkgdown.r-lib.org/articles/customise.html.

@brookslogan
Copy link
Contributor

brookslogan commented Dec 11, 2023

Because dev currently has a 4-digit version number, merging this will likely only update the dev site... which appears not to have been built successfully yet; the expected landing page gives a 404. Maybe merging will give it a chance to build with the epidatr sync [& ds/clean] PR[s].

@brookslogan brookslogan merged commit 31f6319 into dev Dec 11, 2023
0 of 2 checks passed
@brookslogan brookslogan deleted the djm/pkgdown-prettier branch December 11, 2023 23:33
@brookslogan
Copy link
Contributor

Oh, dev didn't exist because #383 wasn't finished yet. No wonder there were no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants