-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pkgdown actions based on branch reorganization #383
Conversation
Also, remove references to defunct/never-existing `master` branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DESCRIPTION file on dev
needs a 4-component version number (x.x.x.x) to trigger the dev-site behavior. Without this, the dev
site will keep overwriting the main
public version. The main
version needs to be a 3-component number (x.x.x). Some more info and links in this PR.
4-component versions complicates automated version bumping, if that's set up in this repo. That will need to be addressed in any workflow files, or noted in any instructions for manual releases.
Recommend including info somewhere about how this works on the public site and how to generate local previews. This is the text I included for developers of epidatr
.
This seems like a good PR to bump our package version to dev release. Could you change the version to 0.7.0.9000? |
Ah I see the version bump happened in #377 |
Co-authored-by: nmdefries <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be good to go after #385
Thanks @dshemetov for addressing the issues. Are we still missing release process documentation as mentioned by @nmdefries? If so, should we put that in another Issue or handle it here? |
Fine to handle it here.
|
Goal is to have separate main & dev documentation sites, with different styling, like cmu-delphi/epidatr. Plus some miscellaneous small updates thrown in. [Before, we only would run pkgdown checks on PRs to dev, not render&update the actual site on pushes to dev, since it would clobber the main version of the site.]