-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistence to API keys #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this so that all of the api key and authorization token fields across the different endpoints share the same singular backing store? That will save the user from having to enter their key into the forms of each individual endpoint, plus our permissions model allows us to grant permission to multiple endpoints via just one key (so a user should never need a plurality of keys).
Can we move the "Save API keys & auth tokens" checkbox next to or right above the "FETCH DATA" button, and can we make it default to unchecked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there is still one more superfluous variable, but otherwise this is probably good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #63.
apiKeySelections
. This is populated when the application is initially launched, and saved in the browser's local storage.