-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu restructuring #996
Menu restructuring #996
Conversation
✅ Deploy Preview for cmu-delphi-main ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Will the "NEW" tags show up when this is published on the live site? They seem unnecessary (but I guess they appear automatically?) |
@carlynvandyke yeah, that "new" tag appears automatically. But there should be way to remove it, so I can try to do that. |
I think we should cut down on text in the first dropdown menu (this is probably more of an item for @RoniRos's review). Here's what I would propose:
We'll have a lot more detail on each individual page so I don't think we need to worry about including too much in the menu. I'm even wondering the two bulletpoints under "Help Us" could be combined into one page/form- seems like it might be easier to keep track of incoming messages that way. |
I agree. |
Notes from 7/23:
|
@dmytrotsko is this done and ready to review? |
My initial thoughts on layout (CC @RoniRos). These could be added in a separate PR if we want to get the initial menu changes out sooner:
|
Thank you @nmdefries , this is extremely helpful feedback.
Ok. Your suggestions below will indeed shorten it by 3, and improve descriptiveness.
Good catch, thank you. Since this menu is for non-programmers, I'd leave the Signal Documentation, which should link directly to the signal documentation section (https://cmu-delphi.github.io/delphi-epidata/api/covidcast_signals.html), albeit currently only the COVIDcast endpoint). I'd like to move the link to https://cmu-delphi.github.io/delphi-epidata/ to the "modelers and developers" menu. Maybe call it "Epidata API documentation"? But note that there is already a link there called "Epidata" under "API and clients" which links to the Epidata code (https://github.com/cmu-delphi/delphi-epidata). Any suggestions on what to call these two distinct links?
Correct. For some reason the signal discovery app cannot be viewed in this staging website.
@dmytro will add the relevant forms shortly.
I like "Report a data problem". Thanks.
Agreed. Will do.
Agreed. Will remove.
Agreed. Thanks.
I like "Signal Download", because it includes also downloading of multiple signals.
I think the current name is more descriptive, and and "signal health" leaves one wondering what is meant by that.
Yes, these forms are ready and @dmytrotsko will add them shortly. The plan is to have 3 separate categories, catering to very different use cases: paid positions, faculty, students & volunteers.
It used to be "careers". I didn't like it, because I think of what we offer more as an invitation to join our mission rather than a career step. But we can talk about it.
Thanks. Yes! Do you want to suggest specific links? Should they follow the same high level structure as the menu? Or something different? In the meantime, @dmytrotsko, can you replace the "Terms" link at the bottom with the new version of the "Terms of Use"? @dmytrotsko I updated the layout document, you can see the requested changes in the version history (including some changes in order of pages, naming, etc. |
What is the goal of linking to the doc site landing page, specifically? Right now in the "epidemic signals" menu, we have links to let users:
Everything up to and including "signal docs" seems useful (except the "status/availability" -- useful, but I'm not sure how much the average user will look at it. Maybe "status/availability" should also go under the "viz" submenu?), and the flow of steps is logical. I think the piece that's missing is "download data using code" -- whether this should go here or in the developers tab depends on how much we think the average user will use code/the API clients to fetch data. Second, if we wanted to provide users with a guide on how to fetch data using the API clients, the doc site landing page isn't what I'd link. Instead, it would be a good place to put the "quickstart" guide suggested in the layout doc. (The The doc site landing page is almost the opposite of a quickstart guide. In that sense, it is better suited for developers.
The "developers" items link to a mix of code (GitHub repos; for In summary, I think the doc site landing page should replace the existing "Epidata" link in the developers submenu (and we should replace the |
RE bottom of page links, I don't have strong thoughts. Normally sites make them "about the org", terms of use, license, privacy policy, contact us, careers, etc. Kind of boring organizational stuff. Sometimes with big projects linked -- could be good to include our GitHub and the Epidata doc site. |
I agree there should be only one link to signal documentation from the "epidemic signals" menu. As you pointed out, the current link is to the COVIDcast endpoint signals only, so I thought it might be better to point to the doc site landing page, where they will hopefully notice in the left-handed menu both the COVIDcast signals and the other signals. But if you think it's better to point directly to the COVIDcast signals, I'm okay with that.
That's a reasonable alternative location. I have a slight preference for keeping status/availability in the main "epidemic signals" menu, but again here, if you have a strong preference for moving it to the "viz' submenu, I'm okay with that.
Maybe an even better place for it is within the "signal download" page, or in a "signal download" submenu?
I designed the "epidemic signals" menu for non-programmers. So my bias is to put the "quickstart guide" under "for modelers and developers" (I think of "developers" as almost synonymous with "programmers"). We can make this point slightly more salient by changing the order in the menu name, namely, "For Developers and Modelers". Or maybe even "For Programmers and Modelers"?
Got it. As I mention above, I was only suggesting it as the doc link in the "epidemic signals" menu as a common root to all signal documentation. I suppose the right solution is to change our documentation tree to merge the two signal menus. But I suspect this is a bit complicated, because there are bits of documentation that are relevant only to the covidcast endpoint. A fast, temporary solution is to put both signal menus under a common "signal documentation" menu, but that will increase the depth of the tree. Other menu rearrangements are also possible. Any ideas?
Okay. I am happy to yield the "Modelers & Developers" menu completely to your design and preferences. Same btw with the "Nowcasting & Forecasting" menu.
I guess the only substantive disagreement we may still have is over the right place for a "quick-start" item. I view it as "quick start for programmers", and therefore feel it should be in their menu. I also love how sparse our top level menu is, so am leaning towards not expanding it. Would it help if we hash this out "in person"? Notwithstanding this last unresolved point, can you please make choices about the first few points above, design the "Developers/Programmers and Modelers" menu as you see fit, reflect it all in the layout document, and ask Dmytro to make these changes. We can make a tentative decision about the Quickstart item, and change it in the next deployment. This new design is such an improvement imho that I would like to get it out sooner rather than later. |
I don't have strong thoughts either. We definitely need to include "Terms of Use". Everything else seems like a re-hash of a subset of the menu items, which is fine with me, but I don't know what logic we should use to decide what to include, and how to organize it. In any case, I'd rather not delay our first release for this. I am adding a "Bottom of page" section to the layout document, with a tentative short list -- feel free to add or change as you see fit. |
I have a moderate preference for pointing directly to the signal documentation subsection of the doc site. As I said above, I just don't think the main site is particularly useful for the non-technical user.
Sounds good, I don't have a strong preference.
Sure
Sure
I don't have a strong preference on the name. The current name is fine.
I think it's fine for now to only link directly to the covidcast signal docs. They are of primary interest to users, and the non-covidcast signal docs are findable through the doc site menu. At some point, we may want to combine covidcast and non-covidcast signal pages under one menu, but I'm imaginging that as a change to the doc site, not the main site.
Sure. We shouldn't wait on the quickstart guide, since we'd have to write it first. |
I think the only new change is: "for modelers and developers" -> "API and clients" -> "epidata" link should go to https://cmu-delphi.github.io/delphi-epidata/ |
@dmytrotsko Can you please go over the current web layout document and implement any recent changes? |
Linkchecker results shows that we have 4 broken (404) links, and many redirected pages. Here are the full results. All errors are at the top. |
Thanks! All four of these pages are available in the deployed space, e.g. if you replace the path with https://delphi.cmu.edu . I don't know about the redirections (301s), or hos significant they are. |
The 404 urls should all work in production. AFAICT, the redirects are just from the tool checking " |
<!-- {{ define "breadcrumb" }} | ||
{{ partial "blog/breadcrumb.html" . }} | ||
{{ end }} | ||
{{ end }} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: the blog main page and individual blog articles aren't loading in the preview (all other menu items and footer items load correctly). It looks to me like this is the only code change to the blog, so I'm wondering if this is causing the problem @dmytrotsko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could try commenting it out differently, with the comment inside the definition block instead of around it, as is done in:
{{ define "breadcrumb" }}<!-- no breadcrumb -->{{ end }} |
Alternatively, if we got rid of the breadcrumbs to squash the weird "COVID-19" text that showed up on pages underneath the epidemic-signals/
path, we can change that here:
linkTitle: COVID-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmdefries @melange396 you both were right. Probably comment worked not as expected and caused wrong page rendering.
I don't understand why server does not show any issues/warning. Everything "works" properly, but blog and individual articles are not rendering at all. But sometimes that happens 👍
Changed "About" and "Epidemic Signals" sections