-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffmpeg: add strip argument to fix cross compilation issues #15459
ffmpeg: add strip argument to fix cross compilation issues #15459
Conversation
I detected other pull requests that are modifying ffmpeg/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit e3d81c9ffmpeg/5.0
ffmpeg/4.4.3
ffmpeg/4.4
ffmpeg/4.2.1
ffmpeg/4.3.2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has suffered from CI issues during the past days, it should be triggered again. |
This comment has been minimized.
This comment has been minimized.
Hey @SpaceIm , I tried to trigger the build again but it has still some strange issues. I guess, i would need to trigger it once more. Is there another way to do this except pushing a new commit? |
enables proper linking for Android
Close/wait 30s/re-open PR |
This comment has been minimized.
This comment has been minimized.
@kambala-decapitator I would appreciate if you like to merge yours into this PR. Than we could follow this here together. At least there were already some reviewers here :) Would that work? |
Sure! Let's do like that. Please add my changes then. |
…-center-index into fix-ffmpeg-strip-program
@kambala-decapitator Done :) |
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 7 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit 220b9a9ffmpeg/4.4
ffmpeg/4.4.3
ffmpeg/5.0
ffmpeg/4.3.2
ffmpeg/4.2.1
|
Specify library name and version: ffmpeg/4.4
This PR fixes Bug #11924. It was closed already but as I mentioned there, the provided solution seems to be more a workaround rather than a complete fix and I recently ran in the same error. In my opinion the current recipe is missing to retrieve STRIP environment variable and add it to build arguments, so I tried to provide a solution for it.
fixes #11924