ffmpeg: conan v2 #15818
Closed
ffmpeg: conan v2 #15818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SpaceIm <[email protected]>
Co-authored-by: Esteve Soria <[email protected]>
This reverts commit 4b65c56.
This reverts commit 5ac6ea7.
This was referenced Feb 8, 2023
|
I detected other pull requests that are modifying ffmpeg/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Feb 8, 2023
Closed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@SpaceIm / @prince-chrismc ... I'd like to understand why this keeps failing for me on windows, with errors like: |
Conan v1 pipeline ❌Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
|
@jcar87 The GNU triplet is failing in 1.x and needs your magic touch |
|
I suspect the tools a messing up the paths between the |
| tc.generate() | ||
|
|
||
|
|
||
| if is_msvc(self): |
There was a problem hiding this comment.
I stole this from recipes/coin-utils/all/conanfile.py maybe see if you can build that one?
env = tc.environment()
if is_msvc(self):
compile_wrapper = unix_path(self, self.conf.get("user.automake:compile-wrapper", check_type=str))
ar_wrapper = unix_path(self, self.conf.get("user.automake:lib-wrapper", check_type=str))
env.define("CC", f"{compile_wrapper} cl -nologo")
env.define("CXX", f"{compile_wrapper} cl -nologo")
env.define("LD", "link -nologo")
env.define("AR", f"{ar_wrapper} \"lib -nologo\"")
env.define("NM", "dumpbin -symbols")
env.define("OBJDUMP", ":")
env.define("RANLIB", ":")
env.define("STRIP", ":")
tc.generate(env)
| args.append("--toolchain=msvc") | ||
| if self.settings.compiler == "Visual Studio" and tools.Version(self.settings.compiler.version) <= "12": | ||
| if self.settings.compiler == "Visual Studio" and Version(self.settings.compiler.version) <= "12": |
There was a problem hiding this comment.
in conan 1.57 they added check min vs with raise = false to be 2.0 compatible
ghost
mentioned this pull request
3 tasks
ghost
mentioned this pull request
3 tasks
3 tasks
ghost
mentioned this pull request
3 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #15035, pushing here to share the work, feel free to pull the changes into any other PR and go from there.
It currently fails at the configure step, on Windows (DOS environment, compiler=msvc).
Comparing config.log between the old working recipe (with compiler=VisualStudio) and this one,
the difference is the old config.log had:
whereas the new config.log had
The new config.log is also missing the lines
There were a bunch of others, but the main thing firstly is the LDFLAGS, because without -libpath, nothing links.