Add disabled property in PressableBox #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
leoafarias
requested changes
Jan 29, 2024
| @@ -157,35 +160,48 @@ class PressableWidgetState extends State<Pressable> { | |||
| button: true, | |||
| focusable: onEnabled && _node.canRequestFocus, | |||
| focused: _node.hasFocus, | |||
| child: GestureDetector( | |||
There was a problem hiding this comment.
I think the disabled should behave only for the onTap behavior, we also should not modify the element in the tree through the function returning a widget.
There was a problem hiding this comment.
I'll change the function. However, about the disabled state only affects onTap. Are you sure? In my opinion when disabled is true, all actions involving the Pressable should be deactivated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ticket number
#175
Describe your changes
disabled;disabledfeature inPressableWidgetType of change
Checklist before requesting a review