-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disabled property in PressableBox #183
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
| import 'package:mix/mix.dart'; | ||
|
|
||
| import '../../../helpers/testing_utils.dart'; | ||
|
|
||
| void main() { | ||
| group('Pressable', () { | ||
| const attribute1 = MockIntScalarAttribute(1); | ||
| const attribute2 = MockStringScalarAttribute('attribute2'); | ||
| const attribute3 = MockBooleanScalarAttribute(true); | ||
|
|
||
| testWidgets('Pressable', (tester) async { | ||
| final firstKey = UniqueKey(); | ||
| final secondKey = UniqueKey(); | ||
| await tester.pumpWidget(Column( | ||
| children: [ | ||
| Pressable( | ||
| onPressed: () {}, | ||
| child: Container( | ||
| key: firstKey, | ||
| ), | ||
| ), | ||
| Pressable( | ||
| onPressed: null, | ||
| disabled: true, | ||
| child: Container( | ||
| key: secondKey, | ||
| ), | ||
| ), | ||
| ], | ||
| )); | ||
|
|
||
| final onEnabledAttr = onEnabled(attribute1, attribute2, attribute3); | ||
|
|
||
| final firstContext = tester.element(find.byKey(firstKey)); | ||
| final secondContext = tester.element(find.byKey(secondKey)); | ||
|
|
||
| final firstNotifier = WidgetStateNotifier.of(firstContext); | ||
| final secondNotifier = WidgetStateNotifier.of(secondContext); | ||
|
|
||
| expect(onEnabledAttr.when(firstContext), true); | ||
| expect(firstNotifier!.status, WidgetStatus.enabled); | ||
| expect(onEnabledAttr.when(secondContext), false); | ||
| expect(secondNotifier!.status, WidgetStatus.disabled); | ||
| }); | ||
|
|
||
| testWidgets('must be clickable when isDisabled is setted to false', | ||
| (tester) async { | ||
| int counter = 0; | ||
|
|
||
| await tester.pumpWidget( | ||
| Pressable( | ||
| onPressed: () { | ||
| counter++; | ||
| }, | ||
| disabled: false, | ||
| child: Container(), | ||
| ), | ||
| ); | ||
|
|
||
| final pressableFinder = find.byType(Pressable); | ||
| expect(pressableFinder, findsOneWidget); | ||
|
|
||
| await tester.tap(pressableFinder); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| expect(counter, 1); | ||
| }); | ||
|
|
||
| testWidgets('must be unclickable when isDisabled is setted to true', | ||
| (tester) async { | ||
| int counter = 0; | ||
|
|
||
| await tester.pumpWidget( | ||
| Pressable( | ||
| onPressed: () { | ||
| counter++; | ||
| }, | ||
| disabled: true, | ||
| child: Container(), | ||
| ), | ||
| ); | ||
|
|
||
| final pressableFinder = find.byType(Pressable); | ||
| expect(pressableFinder, findsOneWidget); | ||
|
|
||
| await tester.tap(pressableFinder); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| expect(counter, 0); | ||
| }); | ||
| }); | ||
|
|
||
| group('PressableBox', () { | ||
| testWidgets('must be clickable when isDisabled is setted to false', | ||
| (tester) async { | ||
| int counter = 0; | ||
|
|
||
| await tester.pumpWidget( | ||
| PressableBox( | ||
| unpressDelay: Duration.zero, | ||
| animationDuration: Duration.zero, | ||
| onPressed: () { | ||
| counter++; | ||
| }, | ||
| disabled: false, | ||
| child: Container(), | ||
| ), | ||
| ); | ||
|
|
||
| final pressableFinder = find.byType(PressableBox); | ||
| expect(pressableFinder, findsOneWidget); | ||
|
|
||
| await tester.tap(pressableFinder); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| expect(counter, 1); | ||
| }); | ||
|
|
||
| testWidgets('must be unclickable when isDisabled is setted to true', | ||
| (tester) async { | ||
| int counter = 0; | ||
|
|
||
| await tester.pumpWidget( | ||
| PressableBox( | ||
| onPressed: () { | ||
| counter++; | ||
| }, | ||
| unpressDelay: Duration.zero, | ||
| animationDuration: Duration.zero, | ||
| disabled: true, | ||
| child: Container(), | ||
| ), | ||
| ); | ||
|
|
||
| final pressableFinder = find.byType(PressableBox); | ||
| expect(pressableFinder, findsOneWidget); | ||
|
|
||
| await tester.tap(pressableFinder); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| expect(counter, 0); | ||
| }); | ||
| }); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the disabled should behave only for the onTap behavior, we also should not modify the element in the tree through the function returning a widget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change the function. However, about the disabled state only affects
onTap. Are you sure? In my opinion when disabled istrue, all actions involving thePressableshould be deactivated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tilucasoli makes sense!