Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge configuration files into pyproject.toml #829

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

marcoesters
Copy link
Contributor

Description

Convert config files into pyproject.toml to use more modern python packaging practices.

The lower bounds for setuptools and setuptools_scm[toml] were taken from menuinst. I'm not sure if they need to be adjusted or can be removed altogether.

Also add setuptools to host dependencies since it will be removed from pip's run dependencies on conda-forge eventually.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 31, 2024
@marcoesters marcoesters marked this pull request as ready for review July 31, 2024 21:08
@marcoesters marcoesters requested a review from a team as a code owner July 31, 2024 21:08
pyproject.toml Outdated Show resolved Hide resolved
.flake8 Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot we have this in pyproject.toml too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 unfortunately doesn't support pyproject.toml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. We could move to ruff in a subsequent PR and get rid of this too.

constructor/_version.py Outdated Show resolved Hide resolved
constructor/__init__.py Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@marcoesters marcoesters requested a review from jaimergp August 1, 2024 15:32
@jaimergp jaimergp merged commit 66c58d4 into conda:main Aug 7, 2024
18 checks passed
@jaimergp jaimergp mentioned this pull request Aug 9, 2024
3 tasks
@marcoesters marcoesters deleted the pyproject-toml branch December 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants