Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge configuration files into pyproject.toml #829

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Merge configuration files into pyproject.toml #829

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f6adfa5
Add setuptools to host requirements
marcoesters Jul 31, 2024
0ae26a6
Convert setup.* files into pyproject.toml
marcoesters Jul 31, 2024
3ed3b31
Add news
marcoesters Jul 31, 2024
7a853e4
Move version dunder into init
marcoesters Jul 31, 2024
48c5d57
Apply suggestions from code review
marcoesters Aug 1, 2024
01774af
Update constructor/__init__.py
marcoesters Aug 1, 2024
237ec3d
Add _version.py to gitignore
marcoesters Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .flake8
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot we have this in pyproject.toml too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 unfortunately doesn't support pyproject.toml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. We could move to ruff in a subsequent PR and get rid of this too.

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[flake8]
max-line-length = 100
8 changes: 5 additions & 3 deletions constructor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from . import _version

__version__ = _version.get_versions()['version']
try:
from . import _version
__version__ = _version.__version__
except ImportError:
__version__ = "dev"
Loading
Loading