Skip to content

Commit

Permalink
Revert "Add a FIXME about unstable name lookups"
Browse files Browse the repository at this point in the history
This reverts commit e2324dd.

Signed-off-by: Paul Holzinger <[email protected]>
  • Loading branch information
Luap99 committed Nov 4, 2024
1 parent 4de7567 commit f0f87a9
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions libimage/pull.go
Original file line number Diff line number Diff line change
Expand Up @@ -533,14 +533,6 @@ func (r *Runtime) copySingleImageFromRegistry(ctx context.Context, imageName str
if options.OS != runtime.GOOS {
lookupImageOptions.OS = options.OS
}
// FIXME: We sometimes return resolvedImageName from this function.
// The function documentation says this returns an image ID, resolvedImageName is frequently not an image ID.
//
// Ultimately Runtime.Pull looks up the returned name... again, possibly finding some other match
// than we did.
//
// This should be restructured so that the image we found here is returned to the caller of Pull
// directly, without another image -> name -> image round-trip and possible inconsistency.
localImage, resolvedImageName, err = r.LookupImage(imageName, lookupImageOptions)
if err != nil && !errors.Is(err, storage.ErrImageUnknown) {
logrus.Errorf("Looking up %s in local storage: %v", imageName, err)
Expand Down

0 comments on commit f0f87a9

Please sign in to comment.