layer tree: handle more errors #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold don't merge, still WIP |
Luap99
reviewed
Jun 26, 2023
There was a problem hiding this comment.
Should
Line 404 in 09caaf6
storage.ErrNotAnImage
|
@Luap99 great idea |
|
/hold cancel |
|
Good to go from my end. containers/podman#18980 is green. |
edsantiago
reviewed
Jun 26, 2023
Commit 97961a6 took a first stab at making operating on the layer tree more resilient by detecting unknown-image errors. Testing in containers/podman/pull/18980 revealed that we also need to detect unknown-layer and -size errors as well. Move the errors checks into a convenience function and update the relevant call sites to facilitate future changes. Export the function since Podman needs the very same checks when operating on images, for instance, when looking up image labels. Signed-off-by: Valentin Rothberg <[email protected]>
|
/lgtm |
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jun 26, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
ashley-cui
pushed a commit
to ashley-cui/podman
that referenced
this pull request
Jul 13, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 97961a6 took a first stab at making operating on the layer
tree more resilient by detecting unknown-image errors. Testing in
containers/podman/pull/18980 revealed that we also need to detect
unknown-layer and -size errors as well.
Move the errors checks into a convenience function and update the
relevant call sites to facilitate future changes. Export the
function since Podman needs the very same checks when operating
on images, for instance, when looking up image labels.