make image listing more resilient #18980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
|
Draft until containers/common#1520 is merged. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Luap99
reviewed
Jun 23, 2023
There was a problem hiding this comment.
I would love for @edsantiago to have a look at the test.
code LGTM
edsantiago
reviewed
Jun 23, 2023
|
LGTM once the tests are hip and @edsantiago 's comments are addressed. |
|
Need another PR in c/common. I am pretty happy about the test as it's quite helpful in finding (more) issues. |
vrothberg
added a commit
to vrothberg/common
that referenced
this pull request
Jun 26, 2023
Commit 97961a6 took a first stab at making operating on the layer tree more resilient by detecting unknown-image errors. Testing in containers/podman/pull/18980 revealed that we also need to detect unknown-layer and -size errors as well. Move the errors checks into a convenience function and update the relevant call sites to facilitate future changes. Signed-off-by: Valentin Rothberg <[email protected]>
|
Now vendoring containers/common#1522 which is needed to address more errors that popped up. I've been running the test for the past 20 mins on my machine but let's see what CI says. |
vrothberg
added a commit
to vrothberg/common
that referenced
this pull request
Jun 26, 2023
Commit 97961a6 took a first stab at making operating on the layer tree more resilient by detecting unknown-image errors. Testing in containers/podman/pull/18980 revealed that we also need to detect unknown-layer and -size errors as well. Move the errors checks into a convenience function and update the relevant call sites to facilitate future changes. Export the function since Podman needs the very same checks when operating on images, for instance, when looking up image labels. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
bz-2216700
branch
2 times, most recently
from
a080bf2 to
93ea7a8
Compare
vrothberg
added a commit
to vrothberg/common
that referenced
this pull request
Jun 26, 2023
Commit 97961a6 took a first stab at making operating on the layer tree more resilient by detecting unknown-image errors. Testing in containers/podman/pull/18980 revealed that we also need to detect unknown-layer and -size errors as well. Move the errors checks into a convenience function and update the relevant call sites to facilitate future changes. Export the function since Podman needs the very same checks when operating on images, for instance, when looking up image labels. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
added a commit
to vrothberg/common
that referenced
this pull request
Jun 26, 2023
Commit 97961a6 took a first stab at making operating on the layer tree more resilient by detecting unknown-image errors. Testing in containers/podman/pull/18980 revealed that we also need to detect unknown-layer and -size errors as well. Move the errors checks into a convenience function and update the relevant call sites to facilitate future changes. Export the function since Podman needs the very same checks when operating on images, for instance, when looking up image labels. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
bz-2216700
branch
2 times, most recently
from
c1e1074 to
2741635
Compare
|
Almost green and ready to merge |
openshift-ci
bot
added
the
do-not-merge/hold
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
|
@vrothberg this is a new (to me) error: Is there any chance your code could've caused this? |
It is not obvious to me but "never say never". Let's keep an eye on it. |
edsantiago
approved these changes
Jun 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Flake turned out to be the unmount/EINVAL one (#18831), which is well known. This PR LGTM. |
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 which does the same on the internal layer tree.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700
Does this PR introduce a user-facing change?