from_env: Use default base_url if no environment is given #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajinamit
force-pushed
the
default-base-url
branch
4 times, most recently
from
46788b4
to
b2d4682
Compare
The PodmanClient class has its own mechanism to detect the default value for base_url if no specific value is provided. However this mechanism can't be used when creating an instance by from_env, because from_env requires (DOCKER|CONTAINER)_HOST environment. This drops the validation from from_env, so that users can use from_env without explicitly setting the HOST environment. Signed-off-by: Takashi Kajinami <[email protected]>
... to resolve the lint failure in CI. Signed-off-by: Takashi Kajinami <[email protected]>
kajinamit
force-pushed
the
default-base-url
branch
from
b2d4682
to
13cb09a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kajinamit, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I wonder if I can request a new release so that this fix is available in a released version . |
|
Should be a new release with podman 5.0 next week. |
|
@umohnani8 PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PodmanClient class has its own mechanism to detect the default value for base_url if no specific value is provided. However this mechanism can't be used when creating an instance by from_env, because from_env requires (DOCKER|CONTAINER)_HOST environment.
This drops the validation from from_env, so that users can use from_env without explicitly setting the HOST environment.