Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from_env: Use default base_url if no environment is given #372

Merged
merged 2 commits into from
Feb 12, 2024
Merged

from_env: Use default base_url if no environment is given #372

merged 2 commits into from
Feb 12, 2024

Commits on Feb 12, 2024

  1. from_env: Use default base_url if no environment is given 

    The PodmanClient class has its own mechanism to detect the default
value for base_url if no specific value is provided. However this
mechanism can't be used when creating an instance by from_env, because
from_env requires (DOCKER|CONTAINER)_HOST environment.

This drops the validation from from_env, so that users can use from_env
without explicitly setting the HOST environment.

Signed-off-by: Takashi Kajinami <[email protected]>
    @kajinamit
    kajinamit committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    4a139fa View commit details
    Browse the repository at this point in the history

  2. Run black format 

    ... to resolve the lint failure in CI.

Signed-off-by: Takashi Kajinami <[email protected]>
    @kajinamit
    kajinamit committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    13cb09a View commit details
    Browse the repository at this point in the history