-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default QEMU CPU level to qemu64
on Windows amd64
#19518
Change default QEMU CPU level to qemu64
on Windows amd64
#19518
Conversation
I'll try to test this before my PTO |
@gbraad if you want to test it end to end you will need as well adding: Both PRs are rebased and applies nicely to the latest code. I also have the notes on how to init machine for Windows and QEMU (which additional parameters in cmd line are needed comparing to WSL or QEMU on other platforms) available here. |
Do we have any updates on this? |
70ee148
to
8293a49
Compare
@gbraad Friendly ping. |
I have it in a branch with 2 other commits https://github.com/arixmkii/podman/tree/qcw-2023-09-30-3 This branch then can be tested with machine e2e tests (documentation update included in the topmost commit) In isolation the change could be tests without rebuilds just following instructions on how to run Podman with QEMU on Windows from here https://github.com/containers/podman/blob/36f8e78d718e1a47727dce798e9bbe4881c53099/docs/tutorials/qemu-remote-tutorial.md#qemu-1 One will need to adjust |
@gbraad @baude @ashley-cui PTAL |
LGTM |
8293a49
to
fd084d5
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
ignore eln for now |
@baude waiting on you. |
Re-Ping @baude |
Signed-off-by: Arthur Sengileyev <[email protected]>
fd084d5
to
4c249a2
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arixmkii, baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Originally
max
level with exceptions was used, because netavark could not work withqemu64
, because there were needed SIMD instructions blocked. Now it works w/o any issues. What could have changed in between:This has been verified to work on:
SW versions:
All test were run with SMP 1 and SMP 4.
max
level in Hyper-V was always getting stuck during boot sequence (in different stages for SMP 1 and SMP 4 (SMP 1 was completing slightly more actions, but never fully booted the VM)).I don't have any AMD machines for testing, but I expect
qemu64
to be more stable for AMD as well as it should hide almost all of the specifics of the CPU in question.No release note, as there were no releases for Windows QEMU yet.
No tests as this is only the default settings changed and no logic changes.
Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED]