Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default QEMU CPU level to qemu64 on Windows amd64 #19518

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Change default QEMU CPU level to qemu64 on Windows amd64 #19518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pkg/machine/qemu/options_windows_amd64.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@ var (
)

func (v *MachineVM) addArchOptions(_ *setNewMachineCMDOpts) []string {
// "max" level is used, because "host" is not supported with "whpx" acceleration
// "vmx=off" disabled nested virtualization (not needed for podman)
// QEMU issue to track nested virtualization: https://gitlab.com/qemu-project/qemu/-/issues/628
// "monitor=off" needed to support hosts, which have mwait calls disabled in BIOS/UEFI
opts := []string{"-machine", "q35,accel=whpx:tcg", "-cpu", "max,vmx=off,monitor=off"}
// "qemu64" level is used, because "host" is not supported with "whpx" acceleration.
// It is a stable choice for running on bare metal and inside Hyper-V machine with nested virtualization.
opts := []string{"-machine", "q35,accel=whpx:tcg", "-cpu", "qemu64"}
return opts
}

Expand Down