-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-ci] [CI:BUILD] FCOS+podman-next: correct GHA conditional syntax #20153
[skip-ci] [CI:BUILD] FCOS+podman-next: correct GHA conditional syntax #20153
Conversation
I guess won't be a bad idea to build twice a day at least until the wait-for-copr stuff is fixed. |
another situation i'm kinda concerned about: Job A using an older commit takes longer to run through the entire process (copr + GHA) but Job B on a newer commit finishes faster. Wonder if we should do something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
FWIW, there's basically no point in running CI for branch-only GHA workflows. Feel free to use the |
effa295
to
9eba07e
Compare
Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-contexts [skip-ci] Signed-off-by: Lokesh Mandvekar <[email protected]>
These are some of the risks with 'latest' tagged images. I wouldn't worry about it, I think you've had enough followup PRs for this, no reason to tempt that dragon more 🤣 |
9eba07e
to
59ffea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a5c7b0e
into
containers:main
Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-contexts
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?