Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] [CI:BUILD] FCOS+podman-next: correct GHA conditional syntax #20153

Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 26, 2023

Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-contexts

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2023
@lsm5 lsm5 requested a review from cevich September 26, 2023 13:58
@lsm5
Copy link
Member Author

lsm5 commented Sep 26, 2023

I guess won't be a bad idea to build twice a day at least until the wait-for-copr stuff is fixed.

@lsm5
Copy link
Member Author

lsm5 commented Sep 26, 2023

another situation i'm kinda concerned about: Job A using an older commit takes longer to run through the entire process (copr + GHA) but Job B on a newer commit finishes faster.

Wonder if we should do something like cancel all prior jobs older than 2 hours if a new one is triggered given the GHA takes 1+ hour to complete.

Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@cevich
Copy link
Member

cevich commented Sep 26, 2023

FWIW, there's basically no point in running CI for branch-only GHA workflows. Feel free to use the [skip-ci] magic PR description string.

@lsm5 lsm5 changed the title [CI:BUILD] FCOS+podman-next: correct GHA conditional syntax [skip-ci] [CI:BUILD] FCOS+podman-next: correct GHA conditional syntax Sep 26, 2023
@lsm5 lsm5 force-pushed the fcos-podman-next-followup-3 branch from effa295 to 9eba07e Compare September 26, 2023 14:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@cevich
Copy link
Member

cevich commented Sep 26, 2023

Wonder if we should do something like cancel all prior jobs older than 2 hours if a new one is triggered given the GHA takes 1+ hour to complete.

These are some of the risks with 'latest' tagged images. I wouldn't worry about it, I think you've had enough followup PRs for this, no reason to tempt that dragon more 🤣

@lsm5 lsm5 force-pushed the fcos-podman-next-followup-3 branch from 9eba07e to 59ffea8 Compare September 26, 2023 14:35
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a5c7b0e into containers:main Sep 26, 2023
25 of 43 checks passed
@lsm5 lsm5 deleted the fcos-podman-next-followup-3 branch September 26, 2023 14:44
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants