Adding comments for container options in qm.container #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilia Markelov <[email protected]>
ilimarx
force-pushed
the
qm_container_doc
branch
from
c5f38a8 to
0b5ca68
Compare
Yarboa
reviewed
Jan 6, 2025
| @@ -35,10 +35,24 @@ LimitNOFILE=65536 | |||
| TasksMax=50% | |||
|
|
|||
| [Container] | |||
| # AddCapability | |||
There was a problem hiding this comment.
I would recommend here to use man quadlet also for details
| # AddCapability | ||
| # ------------- | ||
| # Grants all capabilities to the container, increasing flexibility but significantly | ||
| # reducing security. | ||
| AddCapability=all |
| # Unmask | ||
| # ------- | ||
| # Unmasks all systemd services for the container, overriding masking that prevents | ||
| # access to specific services. |
|
|
||
| # Rootfs | ||
| # ------ | ||
| # Defines the root filesystem location for the container. |
There was a problem hiding this comment.
I would specify the QM rootfs partition
| # Rootfs | ||
| # ------ | ||
| # Defines the root filesystem location for the container. | ||
| # The '${ROOTFS}' variable should point to a valid filesystem path. | ||
| Rootfs=${ROOTFS} |
There was a problem hiding this comment.
see previous one is it a container or partitioned filesystem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.