Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding comments for container options in qm.container #678

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adding comments for container options in qm.container #678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions qm.container
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,24 @@ LimitNOFILE=65536
TasksMax=50%

[Container]
# AddCapability
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend here to use man quadlet also for details

# -------------
# Grants all capabilities to the container, increasing flexibility but significantly
# reducing security.
AddCapability=all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above


# Unmask
# -------
# Unmasks all systemd services for the container, overriding masking that prevents
# access to specific services.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Unmask=ALL
SecurityLabelNested=true
SeccompProfile=/usr/share/qm/seccomp.json

# PidsLimit
# ---------
# Disables the PID limit for the container by setting it to -1.
# Without a limit, the container can spawn unlimited processes, potentially exhausting system resources.
PidsLimit=-1

# Comment DropCapability this will allow FFI Tools to surpass their defaults.
Expand All @@ -49,7 +63,16 @@ AddDevice=-/dev/fuse
ContainerName=qm
Exec=/sbin/init
Network=private

# ReadOnly
# --------
# Makes the container's filesystem read-only, enhancing security by preventing modifications.
ReadOnly=true

# Rootfs
# ------
# Defines the root filesystem location for the container.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would specify the QM rootfs partition

# The '${ROOTFS}' variable should point to a valid filesystem path.
Rootfs=${ROOTFS}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous one is it a container or partitioned filesystem?


SecurityLabelNested=true
Expand Down