Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: V5 icons codemod #2732

Merged
merged 3 commits into from
Apr 26, 2024
Merged

feat: V5 icons codemod #2732

merged 3 commits into from
Apr 26, 2024

Conversation

massao
Copy link
Contributor

@massao massao commented Apr 26, 2024

Purpose of PR

Icons v5 have updates props, we remove not supported props and update the values of the size prop.

@massao massao requested a review from denkristoffer April 26, 2024 10:58
@massao massao requested review from damann and a team as code owners April 26, 2024 10:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ae6e101

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Apr 26, 2024 0:03am

@massao massao requested a review from cf-remylenoir April 26, 2024 10:58
denkristoffer
denkristoffer reviewed Apr 26, 2024
View reviewed changes
packages/forma-36-codemod/package.json
@@ -1,7 +1,7 @@
{
"name": "@contentful/f36-codemod",
"description": "Forma 36 Codemod",
"version": "4.5.0",
"version": "5.0.0-alpha.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the deps as well here, we're still pointing to icons v4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, actually I think we don't need the icons dependency here 🤔

@massao massao force-pushed the v5-icons-codemod branch from ae6e101 to dd7db96 Compare April 26, 2024 11:57
@massao massao force-pushed the v5-icons-codemod branch from dd7db96 to ae6e101 Compare April 26, 2024 12:07
@massao massao requested a review from denkristoffer April 26, 2024 12:33
@massao massao merged commit b0ed861 into feat/icons-v5 Apr 26, 2024
3 of 5 checks passed
@massao massao deleted the v5-icons-codemod branch April 26, 2024 14:24
denkristoffer pushed a commit that referenced this pull request Jun 28, 2024
@massao @denkristoffer
feat: V5 icons codemod (#2732)
20126cf 
* feat: update v5 icons codemod remove variant prop and update size props

* chore: update version of codemod

* chore: remove unnecessary dependency
cf-remylenoir pushed a commit that referenced this pull request Jul 17, 2024
@massao @cf-remylenoir
feat: V5 icons codemod (#2732)
60c965c 
* feat: update v5 icons codemod remove variant prop and update size props

* chore: update version of codemod

* chore: remove unnecessary dependency
Lelith pushed a commit that referenced this pull request Aug 16, 2024
@massao @Lelith
feat: V5 icons codemod (#2732)
b57e9b1 
* feat: update v5 icons codemod remove variant prop and update size props

* chore: update version of codemod

* chore: remove unnecessary dependency
This was referenced Aug 23, 2024
Merged
Merged
This was referenced Sep 12, 2024
Merged
Merged
Merged
Lelith pushed a commit that referenced this pull request Oct 23, 2024
@massao @Lelith
feat: V5 icons codemod (#2732)
5959d8e 
* feat: update v5 icons codemod remove variant prop and update size props

* chore: update version of codemod

* chore: remove unnecessary dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkristoffer denkristoffer denkristoffer approved these changes

@damann damann Awaiting requested review from damann damann is a code owner

@cf-remylenoir cf-remylenoir Awaiting requested review from cf-remylenoir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@massao @denkristoffer