Add buildextend-installer command to build installer ISO #306

dustymabe · 2019-02-01T18:03:46Z

No description provided.

dustymabe · 2019-02-01T18:07:09Z

This is a complete WIP PR. It currently does not attempt to integrate with other outstanding PRs that may be needed to structurally build this the correct way in COSA.

Right now you can generate an installer with coreos-assembler buildextend-installer.
It expects the installer dracut module to be embedded in the ostree (currently not upstream)
It expects to find isolinux configuration files in /src/config/isolinux/. For example I have boot.msg and isolinux.cfg inside of that directory on my local system where I've been hacking on this.

dustymabe · 2019-02-01T18:08:58Z

It currently does not attempt to integrate with other outstanding PRs that may be needed to structurally build this the correct way in COSA.

this is a way of saying, let's not get too caught up on the structure just yet.

src/cmd-buildextend-installer

dustymabe · 2019-02-02T00:09:30Z

at least those few comments should be addressed. I've got to take a look at the other PRs and see where this all fits in. Also I just created the github.com/coreos/coreos-installer repo where I'll be posting up the installer code for this.

cgwalters · 2019-02-04T14:26:51Z

I've got to take a look at the other PRs and see where this all fits in

Luckily given we didn't explicitly coordinate, I believe this is actually nicely complementary to my work in
#305

This is about a PXE path (right)? Which will end up dd-ing an image to disk. I assume you've been testing with the "base image" which today is cloud oriented. My PR is about having a base disk image designed for metal.

dustymabe · 2019-02-04T14:53:52Z

I've got to take a look at the other PRs and see where this all fits in

Luckily given we didn't explicitly coordinate, I believe this is actually nicely complementary to my work in
#305

Nice. Sorry I haven't looked at it yet. I'm going to get the bits up at github.com/coreos/coreos-installer today and then have a look at the outstanding PRs you have open here.

This is about a PXE path (right)? Which will end up dd-ing an image to disk. I assume you've been testing with the "base image" which today is cloud oriented. My PR is about having a base disk image designed for metal.

Yeah I've been just using the disk image that we've been building (converting it to raw first).

cgwalters · 2019-02-04T19:38:48Z

So this ISO will boot into the initramfs; in order to do an install one will need to change the kernel command line to point to the target disk image, right?

(Soon we're going to need to cross the "documentation for FCOS" issue)

cgwalters · 2019-02-04T19:42:48Z

Code seems sane to me!

dustymabe · 2019-02-05T08:55:43Z

OK I've done a little knocking down some of these roadblocks:

Right now you can generate an installer with coreos-assembler buildextend-installer.

This is this PR. You'll need to pull down this PR to use it.

It expects the installer dracut module to be embedded in the ostree (currently not upstream)

I've upstreamed my work to https://github.com/coreos/coreos-installer/tree/master

It expects to find isolinux configuration files in /src/config/isolinux/. For example I have boot.msg and isolinux.cfg inside of that directory on my local system where I've been hacking on this.

Opened a PR here for this: coreos/fedora-coreos-config#47. As part of that PR I also have a section that includes the dracut files directly into the OSTree for fast development (see coreos/fedora-coreos-config@a8577b8).

You should be able to:

$ cd $COREOS_ASSEMBLER_CONFIG_GIT
$ git fetch origin pull/47/head:PR47; git checkout PR47
$ git clone https://github.com/coreos/coreos-installer
$ cd -
$ coreos-assembler build
$ coreos-assembler buildextend-installer

You'll then need to copy the generated ISO somewhere and boot it. You can provide command line args: coreos.inst.image_url coreos.inst.install_dev coreos.inst.ignition_url.

This is still very rough around the edges so I only suggest trying this if you like pain and can't wait :)

Also noteworthy is that ignition fails creating the coreos user when trying to actually boot the generated FCOS qcow with the installer dracut module included. Haven't had a chance to debug that one yet.

ashcrow · 2019-02-05T20:31:26Z

src/cmd-buildextend-installer

+        os.chmod(dst, mode)
+
+    # Generate the ISO image
+    run_verbose(['/usr/bin/genisoimage', '-b', 'isolinux.bin', '-c', 'boot.cat',


I'm guessing the genisoimage is pulled in as a dependency of another package. It may be worth adding it to the deps.txt.

👍 - fixed

ashcrow · 2019-02-05T20:33:46Z

/cc @mrguitar

dustymabe · 2019-02-08T17:06:01Z

fixed code review comments, rebased to latest upstream master, and also added an exception to cosa compress to not compress ISO images.

I'm going to lift WIP for now. The other work is still in PRs elsewhere but I think we can go ahead and merge this without bothering anything else.

ashcrow

LGTM

cgwalters

How about a commit message like:

buildextend-installer: New command

This will allow people to use the new installer
https://github.com/coreos/coreos-installer/
to e.g. do PXE installs to bare metal.

cgwalters · 2019-02-08T18:11:18Z

src/cmd-buildextend-installer

+                 '-no-emul-boot', '-boot-load-size', '4', '-boot-info-table',
+                 '-rock', '-J', '--verbose', '-o', tmpisofile, tmpisoroot])
+    checksum = sha256sum_file(tmpisofile)
+    buildmeta['images']['iso'] = {


Eventually we'll want to land a live-iso or so right? How about installer-iso?

I think we're still working out those details as we may just decide to ship one ISO that can do both. Still some details to work out there. Let's cross that in a followup if you don't mind.

jlebon

One minor comment, otherwise LGTM!

src/cmd-buildextend-installer

dustymabe · 2019-02-11T03:10:43Z

How about a commit message like:

buildextend-installer: New command

This will allow people to use the new installer
https://github.com/coreos/coreos-installer/
to e.g. do PXE installs to bare metal.

done. though I s/PXE/ISO/ for now since I haven't specifically addressed that use case yet

dustymabe · 2019-02-11T03:16:53Z

added fixups from CR and rebased on latest master

jlebon

Just some minor nits. But LGTM as is!

src/cmd-buildextend-installer

This will allow people to use the new installer https://github.com/coreos/coreos-installer/ to e.g. do ISO installs to bare metal.

dustymabe · 2019-02-11T16:48:11Z

fixed CR comments from @jlebon

jlebon · 2019-02-11T17:13:35Z

LGTM.
I just tweaked the PR title to include the new command name to make it easier to find in the future.

dustymabe · 2019-02-11T18:52:56Z

I just tweaked the PR title to include the new command name to make it easier to find in the future.

👍 - anyone opposed to merging?

ashcrow

No objections to merge.

jlebon · 2019-02-11T19:28:31Z

Will merge before end of day today if there are no other objections.
Awesome work on this BTW! 👍

mrguitar · 2019-02-12T02:31:06Z

Yeah nice work on this. Only issue I see is I don't think this will work w/ UEFI support, but that should be pretty simple to add later.

Start using the new `buildextend-installer` command from: coreos/coreos-assembler#306

dustymabe added the WIP PR still being worked on label Feb 1, 2019

cgwalters reviewed Feb 1, 2019

View reviewed changes

src/cmd-buildextend-installer Outdated Show resolved Hide resolved

src/cmd-buildextend-installer Outdated Show resolved Hide resolved

src/cmd-buildextend-installer Outdated Show resolved Hide resolved

This was referenced Feb 4, 2019

cmdlib.py: run_verbose() allow capturing output #310

Merged

virt-install: Work with f28 and f29 #309

Merged

dustymabe mentioned this pull request Feb 5, 2019

add isolinux files for installer work coreos/fedora-coreos-config#47

Merged

ashcrow reviewed Feb 5, 2019

View reviewed changes

dustymabe mentioned this pull request Feb 6, 2019

Bare Metal Installer: Attempt to build media based on current strategy coreos/fedora-coreos-tracker#91

Closed

dustymabe removed the WIP PR still being worked on label Feb 8, 2019

dustymabe changed the title ~~WIP: add command to build installer ISO~~ add command to build installer ISO Feb 8, 2019

ashcrow approved these changes Feb 8, 2019

View reviewed changes

cgwalters reviewed Feb 8, 2019

View reviewed changes

jlebon approved these changes Feb 8, 2019

View reviewed changes

src/cmd-buildextend-installer Show resolved Hide resolved

jlebon reviewed Feb 11, 2019

View reviewed changes

src/cmd-buildextend-installer Outdated Show resolved Hide resolved

src/cmd-buildextend-installer Outdated Show resolved Hide resolved

buildextend-installer: New command

9c7124b

This will allow people to use the new installer https://github.com/coreos/coreos-installer/ to e.g. do ISO installs to bare metal.

jlebon changed the title ~~add command to build installer ISO~~ Add buildextend-installer command to build installer ISO Feb 11, 2019

ashcrow approved these changes Feb 11, 2019

View reviewed changes

jlebon mentioned this pull request Feb 11, 2019

RPM package availability openshift/pivot#35

Closed

jlebon merged commit 6c20f93 into coreos:master Feb 11, 2019

jlebon added a commit to jlebon/fedora-coreos-pipeline that referenced this pull request Feb 12, 2019

pipeline: start building installer ISOs

7613f5f

Start using the new `buildextend-installer` command from: coreos/coreos-assembler#306

jlebon mentioned this pull request Feb 12, 2019

pipeline: start building installer ISOs coreos/fedora-coreos-pipeline#44

Merged

dustymabe deleted the installer branch February 15, 2019 20:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add buildextend-installer command to build installer ISO #306

Add buildextend-installer command to build installer ISO #306

dustymabe commented Feb 1, 2019

dustymabe commented Feb 1, 2019

dustymabe commented Feb 1, 2019

dustymabe commented Feb 2, 2019 •

edited

Loading

cgwalters commented Feb 4, 2019

dustymabe commented Feb 4, 2019

cgwalters commented Feb 4, 2019

cgwalters commented Feb 4, 2019

dustymabe commented Feb 5, 2019

ashcrow Feb 5, 2019

dustymabe Feb 8, 2019

ashcrow commented Feb 5, 2019

dustymabe commented Feb 8, 2019

ashcrow left a comment

cgwalters left a comment

cgwalters Feb 8, 2019

dustymabe Feb 11, 2019

jlebon left a comment

dustymabe commented Feb 11, 2019

dustymabe commented Feb 11, 2019

jlebon left a comment

dustymabe commented Feb 11, 2019

jlebon commented Feb 11, 2019

dustymabe commented Feb 11, 2019

ashcrow left a comment

jlebon commented Feb 11, 2019

mrguitar commented Feb 12, 2019

Add buildextend-installer command to build installer ISO #306

Add buildextend-installer command to build installer ISO #306

Conversation

dustymabe commented Feb 1, 2019

dustymabe commented Feb 1, 2019

dustymabe commented Feb 1, 2019

dustymabe commented Feb 2, 2019 • edited Loading

cgwalters commented Feb 4, 2019

dustymabe commented Feb 4, 2019

cgwalters commented Feb 4, 2019

cgwalters commented Feb 4, 2019

dustymabe commented Feb 5, 2019

ashcrow Feb 5, 2019

Choose a reason for hiding this comment

dustymabe Feb 8, 2019

Choose a reason for hiding this comment

ashcrow commented Feb 5, 2019

dustymabe commented Feb 8, 2019

ashcrow left a comment

Choose a reason for hiding this comment

cgwalters left a comment

Choose a reason for hiding this comment

cgwalters Feb 8, 2019

Choose a reason for hiding this comment

dustymabe Feb 11, 2019

Choose a reason for hiding this comment

jlebon left a comment

Choose a reason for hiding this comment

dustymabe commented Feb 11, 2019

dustymabe commented Feb 11, 2019

jlebon left a comment

Choose a reason for hiding this comment

dustymabe commented Feb 11, 2019

jlebon commented Feb 11, 2019

dustymabe commented Feb 11, 2019

ashcrow left a comment

Choose a reason for hiding this comment

jlebon commented Feb 11, 2019

mrguitar commented Feb 12, 2019

dustymabe commented Feb 2, 2019 •

edited

Loading