Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isolinux files for installer work #47

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Conversation

dustymabe
Copy link
Member

No description provided.

@dustymabe
Copy link
Member Author

this is one part of coreos/coreos-assembler#306

@dustymabe
Copy link
Member Author

ok I removed the "hack for fast development" commits from this and am moving from WIP. Let's go ahead and get this reviewed/merged and we'll be one step closer to delivering on this.

@dustymabe dustymabe requested a review from jlebon February 14, 2019 04:28
@dustymabe dustymabe changed the title WIP: add isolinux files for installer work add isolinux files for installer work Feb 14, 2019
fedora-coreos-base.yaml Outdated Show resolved Hide resolved
@dustymabe
Copy link
Member Author

moving back to WIP until we have the rpm available

@dustymabe dustymabe added the WIP PR still being worked on label Feb 14, 2019
@dustymabe dustymabe changed the title add isolinux files for installer work WIP: add isolinux files for installer work Feb 14, 2019
@dustymabe
Copy link
Member Author

ok back out of WIP - we have a copr repo for now with the installer rpm while it goes through code review

@dustymabe dustymabe removed the WIP PR still being worked on label Feb 15, 2019
@dustymabe dustymabe changed the title WIP: add isolinux files for installer work add isolinux files for installer work Feb 15, 2019
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional observation, but don't block on it. Otherwise seems sane to me.

@@ -14,6 +14,7 @@ repos:
- fedora
- fedora-updates
- dustymabe-ignition
- dustymabe-coreos-installer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not sure it's really worth having multiple COPRs, easier to have a shared one?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i thought about that. we'll rip these both out pretty soon (#52) and if we need to add a copr back we'll make a combined one

isolinux/boot.msg Outdated Show resolved Hide resolved
@jlebon
Copy link
Member

jlebon commented Feb 15, 2019

Looks good to me!
Will let @yrobla take a look as well.

coreos-installer
    - contains installer script
coreos-installer-dracut
    - contains dracut module for embedding installer in initramfs
These files will be used by CoreOS Assembler to be embedded
into an ISO image that can then be used for installing Fedora
or Red Hat CoreOS.
@cgwalters
Copy link
Member

Looks great thanks!

@cgwalters cgwalters merged commit 9a09dd9 into coreos:master Feb 15, 2019
@dustymabe
Copy link
Member Author

In the final commit I renamed isolinux to installer. Have opened a corresponding PR against COSA: coreos/coreos-assembler#352

c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this pull request Mar 27, 2023
dustymabe pushed a commit to jbtrystram/fedora-coreos-config that referenced this pull request Apr 19, 2024
This updates the FAQ page with fresh details about the current status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants