[rhcos-4.16] kola: add support for simulating 512e disks and add support for primaryDisk key
#3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's come up a few times now that we need to dig into 512e-specific behaviours (most recently in OCPBUGS-35410). Let's add a knob for this in the qemu platform just like the one we have for 4Kn.
Just like we have `additionalDisks`, add a new `primaryDisk` key which takes the same "diskspec" format. This immediately unlocks all the same knobs available to additional disks to the primary disk itself from external tests. E.g. with this, we can now migrate multipath tests to external tests that use `primaryDisk: 20G:mpath`. My immediate motivation for this however is to be able to use the new `512e` disk option from an external test as part of fixing OCPBUGS-35410.
When using the new `primaryDisk` key, allow the diskspec to omit the size component, in which case we don't resize the boot disk.
|
Hi @openshift-cherrypick-robot. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
travier
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3822
/assign travier