kola: add support for simulating 512e disks and add support for primaryDisk key
#3822
Conversation
It's come up a few times now that we need to dig into 512e-specific behaviours (most recently in OCPBUGS-35410). Let's add a knob for this in the qemu platform just like the one we have for 4Kn.
Just like we have `additionalDisks`, add a new `primaryDisk` key which takes the same "diskspec" format. This immediately unlocks all the same knobs available to additional disks to the primary disk itself from external tests. E.g. with this, we can now migrate multipath tests to external tests that use `primaryDisk: 20G:mpath`. My immediate motivation for this however is to be able to use the new `512e` disk option from an external test as part of fixing OCPBUGS-35410.
When using the new `primaryDisk` key, allow the diskspec to omit the size component, in which case we don't resize the boot disk.
|
@jlebon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
RHCOS CI failing on openshift/os#1523 :/ |
|
That's a nice change! Thanks |
|
/cherry-pick rhcos-4.16 |
|
@travier: new pull request created: #3824 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kola/qemu: add support for simulating 512e disks
It's come up a few times now that we need to dig into 512e-specific
behaviours (most recently in OCPBUGS-35410). Let's add a knob for this
in the qemu platform just like the one we have for 4Kn.
kola: add support for
primaryDiskkeyJust like we have
additionalDisks, add a newprimaryDiskkey whichtakes the same "diskspec" format. This immediately unlocks all the same
knobs available to additional disks to the primary disk itself from
external tests.
E.g. with this, we can now migrate multipath tests to external tests
that use
primaryDisk: 20G:mpath.My immediate motivation for this however is to be able to use the
new
512edisk option from an external test as part of fixingOCPBUGS-35410.